Git development
 help / color / mirror / Atom feed
From: Ben Willard <benwillard@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] blame: Fix corner case when a directory becomes a file
Date: Wed, 3 Jun 2009 08:40:45 -0400	[thread overview]
Message-ID: <20090603124045.GB3151@ben-laptop> (raw)
In-Reply-To: <7vr5y1bw4l.fsf@alter.siamese.dyndns.org>

On Wed, Jun 03, 2009 at 12:43:22AM -0700, Junio C Hamano wrote:
> Thanks.
> 
> Your problem analysis is almost correct but the solution is wrong.

Ah, I guess it was more complicated than I thought.

> By the way, I'd rather not see people waste a whole _new_ test script when
> there are existing test scripts availble for the command.

I'll remember that for next time.

> -- >8 --
> Subject: [PATCH] blame: correctly handle a path that used to be a directory
> ...

I tested this patch and it works.

Thanks Junio,
--
Ben

      reply	other threads:[~2009-06-03 12:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-02 19:28 [PATCH 0/2] git-blame bug Ben Willard
2009-06-02 19:28 ` [PATCH 1/2] t8006: Add test to show blame failure Ben Willard
2009-06-02 19:29 ` [PATCH 2/2] blame: Fix corner case when a directory becomes a file Ben Willard
2009-06-03  7:43   ` Junio C Hamano
2009-06-03 12:40     ` Ben Willard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090603124045.GB3151@ben-laptop \
    --to=benwillard@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox