From: Todd Zullinger <tmz@pobox.com>
To: Thomas Rast <trast@student.ethz.ch>
Cc: Junio C Hamano <gitster@pobox.com>,
"Shawn O. Pearce" <spearce@spearce.org>,
Thomas Spura <tomspur@fedoraproject.org>,
git@vger.kernel.org
Subject: [PATCH v2] completion: Add --full-diff to log options
Date: Wed, 3 Jun 2009 16:20:58 -0400 [thread overview]
Message-ID: <20090603202058.GA28808@inocybe.localdomain> (raw)
In-Reply-To: <200906031630.09962.trast@student.ethz.ch>
Signed-off-by: Todd Zullinger <tmz@pobox.com>
---
Thomas Rast wrote:
> Todd Zullinger wrote:
>> I *think* __git_log_gitk_options is the proper place for it, but it's
>> early in the a.m. and I'm not averse to being proved wrong.
> [...]
>> # Options that go well for log and gitk (not shortlog)
>> __git_log_gitk_options="
>> - --dense --sparse --full-history
>> + --dense --sparse --full-diff --full-history
>
> Gitk has its own setting in the Preferences called "limit diffs to
> listed paths", and ignores this option, so it should go directly in
> _git_log.
Ahh, thanks Thomas.
contrib/completion/git-completion.bash | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 98b9cbe..79a99af 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1157,7 +1157,7 @@ _git_log ()
$__git_log_shortlog_options
$__git_log_gitk_options
--root --topo-order --date-order --reverse
- --follow
+ --follow --full-diff
--abbrev-commit --abbrev=
--relative-date --date=
--pretty= --format= --oneline
--
1.6.3.1
--
Todd OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
I have to decide between two equally frightening options. If I wanted
to do that, I'd vote.
-- Duckman
next prev parent reply other threads:[~2009-06-03 20:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 0:34 wrong expectation from "git log -p" Thomas Spura
2009-06-02 0:54 ` Junio C Hamano
2009-06-03 12:22 ` [PATCH] completion: Add --full-diff to log/gitk options Todd Zullinger
2009-06-03 14:30 ` Thomas Rast
2009-06-03 20:20 ` Todd Zullinger [this message]
2009-07-05 8:35 ` [PATCH v2] completion: Add --full-diff to log options Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090603202058.GA28808@inocybe.localdomain \
--to=tmz@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
--cc=tomspur@fedoraproject.org \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).