From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Bert Wesarg <bert.wesarg@googlemail.com>
Cc: Petr Baudis <pasky@suse.cz>,
git@vger.kernel.org, martin f krafft <madduck@debian.org>
Subject: Re: [TopGit PATCH] pre-commit: check .topdeps for valid branches
Date: Thu, 4 Jun 2009 11:34:56 +0200 [thread overview]
Message-ID: <20090604093456.GA14548@pengutronix.de> (raw)
In-Reply-To: <1243976962-10486-1-git-send-email-bert.wesarg@googlemail.com>
Hi Bert,
> diff --git a/hooks/pre-commit.sh b/hooks/pre-commit.sh
> index 8e05a4e..1eae2e8 100644
> --- a/hooks/pre-commit.sh
> +++ b/hooks/pre-commit.sh
> @@ -52,6 +52,9 @@ BEGIN { in_hunk = 0; }
> /^[^@ +-]/ { in_hunk = 0; }
> ' |
> while read newly_added; do
> + ref_exists "$newly_added" ||
> + die "Invalid branch as dependent: $newly_added"
> +
> # deps can be non-tgish but we can't run recurse_deps() on them
> ref_exists "refs/top-bases/$newly_added" ||
> continue
> --
> tg: (0f8cd77..) bw/check-valid-deps (depends on: bw/check-for-dep-cycle)
this patch doesn't apply to my branch. I'd say you didn't send out
bw/check-for-dep-cycle (or I oversaw it).
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2009-06-04 9:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1243592316-10820-1-git-send-email-bert.wesarg@googlemail.com>
2009-06-02 21:09 ` [TopGit PATCH] pre-commit: check .topdeps for valid branches Bert Wesarg
2009-06-04 9:34 ` Uwe Kleine-König [this message]
2009-06-04 12:18 ` Bert Wesarg
2010-10-04 21:07 [TopGit PATCH] hooks/pre-commit: check for cycles in dependencies Bert Wesarg
2010-10-04 21:18 ` [TopGit PATCH] pre-commit: check .topdeps for valid branches Bert Wesarg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090604093456.GA14548@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=bert.wesarg@googlemail.com \
--cc=git@vger.kernel.org \
--cc=madduck@debian.org \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).