From: "Shawn O. Pearce" <spearce@spearce.org>
To: Ferry Huberts <ferry.huberts@pelagic.nl>
Cc: Robin Rosenberg <robin.rosenberg@dewire.com>, git@vger.kernel.org
Subject: Re: [JGIT PATCH 1/2] Add getLong to RepositoryConfig
Date: Sat, 13 Jun 2009 12:21:22 -0700 [thread overview]
Message-ID: <20090613192122.GT16497@spearce.org> (raw)
In-Reply-To: <4A335BD7.60107@pelagic.nl>
Ferry Huberts <ferry.huberts@pelagic.nl> wrote:
> Shawn O. Pearce wrote:
> > This supports parsing 64 bit configuration values.
...
> > + /**
> > + * Obtain an integer value from the configuration.
> s/integer/long/g in this (copy&paste) javadoc part
Its still integer as in from the integer number space, and not say
a floating point decimal. Thus I didn't bother with this edit,
I figured the method name was clear enough that it would return
a long, but the concept of it parsing only "2g" and not "1.5g"
should go in the documentation.
And again, please trim parts you aren't replying to.
--
Shawn.
prev parent reply other threads:[~2009-06-13 19:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-12 23:23 [JGIT PATCH 1/2] Add getLong to RepositoryConfig Shawn O. Pearce
2009-06-12 23:23 ` [JGIT PATCH 2/2] Allow core.packedGitLimit to exceed "2 g" Shawn O. Pearce
2009-06-13 7:56 ` Ferry Huberts
2009-06-13 19:19 ` Shawn O. Pearce
2009-06-14 8:49 ` Ferry Huberts
2009-06-13 7:57 ` [JGIT PATCH 1/2] Add getLong to RepositoryConfig Ferry Huberts
2009-06-13 19:21 ` Shawn O. Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090613192122.GT16497@spearce.org \
--to=spearce@spearce.org \
--cc=ferry.huberts@pelagic.nl \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).