From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
To: Mark Struberg <struberg@yahoo.de>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [EGIT PATCH2/2] fixed-toString-for-CommitTimeRevFilter-wrote-JUnit-tests
Date: Wed, 17 Jun 2009 00:19:08 +0200 [thread overview]
Message-ID: <200906170019.11627.robin.rosenberg.lists@dewire.com> (raw)
In-Reply-To: <168892.81103.qm@web27804.mail.ukl.yahoo.com>
måndag 15 juni 2009 23:36:35 skrev Mark Struberg <struberg@yahoo.de>:
>
> From 72dd9d071ce140f267b8b4effd34d122627135e6 Mon Sep 17 00:00:00 2001
> From: Mark Struberg <struberg@yahoo.de>
> Date: Mon, 15 Jun 2009 08:07:53 +0200
> Subject: [PATCH] fixed toString for CommitTimeRevFilter + wrote JUnit tests for after, before and between walks
What is the connection between the toString and the rest of the patch? Should be
separate patches.
You should sign off the patches.
Start the subject with a capital letter.
Technically it seemed ok, but I shouldn't have pushed them, as I did, by mistake when pusing
Shawn's latest patch. The formal errors should have been fixed firsts.
-- robin
next prev parent reply other threads:[~2009-06-16 22:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-15 21:36 [EGIT PATCH2/2] fixed-toString-for-CommitTimeRevFilter-wrote-JUnit-tests Mark Struberg
2009-06-16 22:19 ` Robin Rosenberg [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-06-17 7:58 Mark Struberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906170019.11627.robin.rosenberg.lists@dewire.com \
--to=robin.rosenberg.lists@dewire.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
--cc=struberg@yahoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).