git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Couder <chriscool@tuxfamily.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org, Stephan Beyer <s-beyer@gmx.net>,
	Daniel Barkalow <barkalow@iabervon.org>
Subject: Re: [PATCH 2/2] rebase -i: use some kind of config file to save author information
Date: Wed, 24 Jun 2009 06:36:04 +0200	[thread overview]
Message-ID: <200906240636.04675.chriscool@tuxfamily.org> (raw)
In-Reply-To: <alpine.DEB.1.00.0906231137220.5252@intel-tinevez-2-302>

Hi,

On Tuesday 23 June 2009, Johannes Schindelin wrote:
> Hi,
>
> On Tue, 23 Jun 2009, Christian Couder wrote:
> > The problem with this is that it will take a lot of time to implement
> > the features that have been added to rebase -i since the sequencer
> > stalled, then to polish it, and to get it reviewed and so on, and
> > during that time other features or changes may be implemented by other
> > people.
> >
> > So I prefer to use code from the current sequencer (at
> > http://repo.or.cz/w/git/sbeyer.git) to start porting step by step
> > rebase -i to C.
>
> I think that the best way to go forward would be to have something like
> fetch--tool, i.e. a builtin helper that successively takes more and more
> functionality into C.

Yeah, I started working on something like that.

> IMHO a first sensible step would be to implement the commands ("pick",
> "squash", "edit") in such a helper, and call them from do_next().
>
> That should take care of the most difficult part, getting the transition
> started.

I agree that it looks like a good way forward.

> But I had the impression that the sequencer started out almost like this,
> but then it also wanted to implement the do_next() and everything.

Yeah, I think at some steps we got something close to that.

Thanks,
Christian.

  reply	other threads:[~2009-06-24  4:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-20  2:34 [PATCH 2/2] rebase -i: use some kind of config file to save author information Christian Couder
2009-06-20  9:27 ` Jakub Narebski
2009-06-21  5:15   ` Christian Couder
2009-06-21 21:55 ` Johannes Schindelin
2009-06-21 23:15   ` Junio C Hamano
2009-06-22  4:50     ` Christian Couder
2009-06-22  9:19     ` Johannes Schindelin
2009-06-23  5:30       ` Christian Couder
2009-06-23  9:40         ` Johannes Schindelin
2009-06-24  4:36           ` Christian Couder [this message]
2009-06-23  4:57     ` Christian Couder
2009-06-23  5:25       ` Junio C Hamano
2009-06-24  4:29         ` Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200906240636.04675.chriscool@tuxfamily.org \
    --to=chriscool@tuxfamily.org \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=barkalow@iabervon.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=s-beyer@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).