From: Jakub Narebski <jnareb@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>,
git@vger.kernel.org, Aaron Crane <git@aaroncrane.co.uk>
Subject: Re: [PATCHv4 0/2] gitweb: gravatar support
Date: Wed, 24 Jun 2009 09:45:45 +0200 [thread overview]
Message-ID: <200906240945.48691.jnareb@gmail.com> (raw)
In-Reply-To: <7vy6riyu5m.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:
>
> > As suggested by Junio, the author display refactoring now comes before
> > the actual gravatar feature implementation. The refactoring also goes a
> > little bit deeper, changing the 'commitdiff' view to match 'commit' for
> > the author and committer layout.
> >
> > Giuseppe Bilotta (2):
> > gitweb: refactor author name insertion
> > gitweb: gravatar support
> >
> > gitweb/gitweb.css | 9 +++-
> > gitweb/gitweb.perl | 123 ++++++++++++++++++++++++++++++++++++++-------------
> > 2 files changed, 99 insertions(+), 33 deletions(-)
>
> Thanks. It looks much better for reviewing, now the order of the patches
> are sane.
>
> Does anybody have comments on the patches?
I'll send my comments today.
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2009-06-24 7:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-22 22:49 [PATCHv4 0/2] gitweb: gravatar support Giuseppe Bilotta
2009-06-22 22:49 ` [PATCHv4 1/2] gitweb: refactor author name insertion Giuseppe Bilotta
2009-06-22 22:49 ` [PATCHv4 2/2] gitweb: gravatar support Giuseppe Bilotta
2009-06-24 13:44 ` Nanako Shiraishi
2009-06-24 20:00 ` Giuseppe Bilotta
2009-06-25 1:35 ` Jakub Narebski
2009-06-25 1:23 ` [PATCHv4 1/2] gitweb: refactor author name insertion Jakub Narebski
2009-06-24 7:20 ` [PATCHv4 0/2] gitweb: gravatar support Junio C Hamano
2009-06-24 7:45 ` Jakub Narebski [this message]
2009-06-24 8:15 ` Nanako Shiraishi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906240945.48691.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@aaroncrane.co.uk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=giuseppe.bilotta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).