Re: [PATCHv7 4/9] gitweb: right-align date cell in shortlog

[Jakub Narebski <jnareb@gmail.com>]

On Sat, 27 June 2009, Giuseppe Bilotta wrote:

> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>

I don't like it.  In my opinion it is less readable that way, especially
if word wrapping gets involved:

  5 hours |
      ago |

  5 hours |
      ago |

   5 days |
      ago |

It is IMVHO a bit ugly.


That aside this is *not complete*.  Take a look at 'summary' view.  
You have there 'date' column in 'shortlog' section aligned to the right,
while in 'heads' and 'tags' section it is aligned to the left.  Add to
that "Last Change" column in projects list view (which should probably
be aligned to the left, even with this patch completed).

NAK from me.  (Alternate stylesheet?  Just kidding...)

> ---
>  gitweb/gitweb.css |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/gitweb/gitweb.css b/gitweb/gitweb.css
> index 68b22ff..ef24a1b 100644
> --- a/gitweb/gitweb.css
> +++ b/gitweb/gitweb.css
> @@ -180,6 +180,10 @@ table {
>  	border-spacing: 0;
>  }
>  
> +table.shortlog td:first-child {
> +	text-align: right;
> +}
> +
>  table.diff_tree {
>  	font-family: monospace;
>  }

On the other hand: it is short and simple.

-- 
Jakub Narebski
Poland