git remote rm non-existant-remote

git remote rm non-existant-remote

[Brian Gernhardt]

I was working on updating the remotes for one of my repositories  
(adding a variety of forks) and renamed the origin branch.  When I was  
done, I tried to use "git remote rm origin" to remove the branches for  
the now dead origin.  What git-remote did was remove all of my remotes  
and the merge information for my master branch (which was moved off  
the origin remote).

This is a data loss bug.  Very bad.  `git remote rm` should either  
refuse to remove a non-existent remote or (preferably) simply remove  
any branches that exist for that remote.

When time allows I'll look into fixing this, but I thought I'd post in  
case somebody had more tuits than me this week.

~~ Brian Gernhardt

Re: git remote rm non-existant-remote

[Jeff King]

On Sun, Jun 28, 2009 at 10:47:23AM -0400, Brian Gernhardt wrote:

> I was working on updating the remotes for one of my repositories
> (adding a variety of forks) and renamed the origin branch.  When I
> was done, I tried to use "git remote rm origin" to remove the
> branches for the now dead origin.  What git-remote did was remove all
> of my remotes and the merge information for my master branch (which
> was moved off the origin remote).
> 
> This is a data loss bug.  Very bad.  `git remote rm` should either
> refuse to remove a non-existent remote or (preferably) simply remove
> any branches that exist for that remote.

Ouch. That is indeed a serious bug. However, I can't reproduce with
current 'next'; which version of git are you using?

> When time allows I'll look into fixing this, but I thought I'd post
> in case somebody had more tuits than me this week.

I think it would be nice to have it delete partial cruft left over, but
I suspect just changing it to refuse the deletion will be a one-liner.
It would be nice to get at least that out to 'maint' branches as
appropriate.

-Peff

Re: git remote rm non-existant-remote

[Brian Gernhardt]

On Jun 28, 2009, at 12:11 PM, Jeff King wrote:

> On Sun, Jun 28, 2009 at 10:47:23AM -0400, Brian Gernhardt wrote:
>
>> I was working on updating the remotes for one of my repositories
>> (adding a variety of forks) and renamed the origin branch.  When I
>> was done, I tried to use "git remote rm origin" to remove the
>> branches for the now dead origin.  What git-remote did was remove all
>> of my remotes and the merge information for my master branch (which
>> was moved off the origin remote).
>>
>> This is a data loss bug.  Very bad.  `git remote rm` should either
>> refuse to remove a non-existent remote or (preferably) simply remove
>> any branches that exist for that remote.
>
> Ouch. That is indeed a serious bug. However, I can't reproduce with
> current 'next'; which version of git are you using?

git version 1.6.3.3.467.g98a79

I believe that's the latest "next".

~~ Brian

Re: git remote rm non-existant-remote

[Jeff King]

On Sun, Jun 28, 2009 at 07:04:17PM -0400, Brian Gernhardt wrote:

> >Ouch. That is indeed a serious bug. However, I can't reproduce with
> >current 'next'; which version of git are you using?
> 
> git version 1.6.3.3.467.g98a79
> 
> I believe that's the latest "next".

OK, then it is not a version problem, but rather I am doing something
different to try to reproduce it. Can you post a short set of commands
to show the problem?

-Peff