From: Jeff King <peff@peff.net>
To: Eric Raible <raible@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: RFH - git-log variant that _does_ search through diffs
Date: Tue, 30 Jun 2009 00:03:37 -0400 [thread overview]
Message-ID: <20090630040337.GA23741@sigio.peff.net> (raw)
In-Reply-To: <279b37b20906291708g67da3a75p316ea4893f02666a@mail.gmail.com>
On Mon, Jun 29, 2009 at 05:08:47PM -0700, Eric Raible wrote:
> [Surely this has been address before, but I wasn't able to find it...]
There is some discussion here:
http://article.gmane.org/gmane.comp.version-control.git/112077
> The documentation for git-log -S includes:
>
> "Look for differences that introduce or remove an instance of <string>.
> Note that this is different than the string simply appearing in diff output"
>
> But I want to do that "different" thing (IOW I want search the diff output).
>
> So must I loop through git-rev-list, grepping git-diff output on each commit?
Currently, yes. There is no way to do it internally. A patch to
implement it would probably be accepted, though (see the thread I
mentioned above for more details).
You can at least combine rev-list and diff into one command, and grep
like this (for 'foo'):
git log -z -p | perl -0ne 'print if /^[-+].*foo/m' | tr '\0' '\n'
-Peff
next prev parent reply other threads:[~2009-06-30 4:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-30 0:08 RFH - git-log variant that _does_ search through diffs Eric Raible
2009-06-30 4:03 ` Jeff King [this message]
2009-06-30 8:09 ` Junio C Hamano
2009-06-30 18:06 ` Eric Raible
2009-06-30 18:05 ` Eric Raible
2009-06-30 19:31 ` Jeff King
2009-06-30 21:22 ` Eric Raible
2009-06-30 21:34 ` Eric Raible
2009-07-01 7:02 ` Jeff King
2009-07-01 7:26 ` [PATCH 1/2] log-tree: fix confusing comment Jeff King
2009-07-01 7:26 ` [RFC/PATCH 2/2] fix missing NUL termination with pretty=tformat Jeff King
2009-07-01 8:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090630040337.GA23741@sigio.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=raible@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).