From: Jeff King <peff@peff.net>
To: Eric Raible <raible@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: RFH - git-log variant that _does_ search through diffs
Date: Tue, 30 Jun 2009 15:31:35 -0400 [thread overview]
Message-ID: <20090630193135.GA4460@sigio.peff.net> (raw)
In-Reply-To: <279b37b20906301105tf92f471g6146a083ba2e2882@mail.gmail.com>
On Tue, Jun 30, 2009 at 11:05:08AM -0700, Eric Raible wrote:
> What I _really_ want is the subset of all commits containing foo
> who's oneline commit message doesn't match a given regexp.
>
> So I'm used something like this to extract the commits of interest:
>
> git log -z -p | perl -0ne 'print if /^[-+].*foo/m' | tr '\0' '\n' |
> grep "^commit [0-9a-f]" | awk '{print $2}' |
> xargs -n1 git log --pretty=oneline -1 |
> grep -v dont_want
I think you can do this a little more simply and efficiently as:
git log -z -p --format='GREP: %s' |
perl -0ne 'print if /^[-+].*foo/m && !/^GREP:.*dont_want/' |
tr '\0' '\n'
(though note that --format is new as of 1.6.3, I think; before that you
have to use "--pretty=format:"). Many fewer process invocations, and
less typing, though still easy to mess up. At one point I had considered
writing small wrapper scripts that understood the log output so you
could say:
git log -z -p | filter-author $A | filter-diff $D | filter-subject $S
which is nicely readable and Unix-y, but is really _slow_ compared to
git doing it all in a single process. I think a "--grep-subject" and a
"--grep-diff" (aka "--search") are the only things that are missing now,
and those would both be pretty easy to implement.
-Peff
next prev parent reply other threads:[~2009-06-30 19:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-30 0:08 RFH - git-log variant that _does_ search through diffs Eric Raible
2009-06-30 4:03 ` Jeff King
2009-06-30 8:09 ` Junio C Hamano
2009-06-30 18:06 ` Eric Raible
2009-06-30 18:05 ` Eric Raible
2009-06-30 19:31 ` Jeff King [this message]
2009-06-30 21:22 ` Eric Raible
2009-06-30 21:34 ` Eric Raible
2009-07-01 7:02 ` Jeff King
2009-07-01 7:26 ` [PATCH 1/2] log-tree: fix confusing comment Jeff King
2009-07-01 7:26 ` [RFC/PATCH 2/2] fix missing NUL termination with pretty=tformat Jeff King
2009-07-01 8:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090630193135.GA4460@sigio.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=raible@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).