git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Eric Raible <raible@gmail.com>, Git Mailing List <git@vger.kernel.org>
Subject: [PATCH 1/2] log-tree: fix confusing comment
Date: Wed, 1 Jul 2009 03:26:28 -0400	[thread overview]
Message-ID: <20090701072628.GA8101@sigio.peff.net> (raw)
In-Reply-To: <20090701070252.GA7987@sigio.peff.net>

This comment mentions the case where use_terminator is set,
but this case is not handled at all by this chunk of code.

Signed-off-by: Jeff King <peff@peff.net>
---
This comment confused me quite a bit while tracking down the issue in
2/2.

 log-tree.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/log-tree.c b/log-tree.c
index 59d63eb..6f73c17 100644
--- a/log-tree.c
+++ b/log-tree.c
@@ -321,7 +321,8 @@ void show_log(struct rev_info *opt)
 	}
 
 	/*
-	 * If use_terminator is set, add a newline at the end of the entry.
+	 * If use_terminator is set, we already handled any record termination
+	 * at the end of the last record.
 	 * Otherwise, add a diffopt.line_termination character before all
 	 * entries but the first.  (IOW, as a separator between entries)
 	 */
-- 
1.6.3.3.485.g0f5d4.dirty

  reply	other threads:[~2009-07-01  7:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-30  0:08 RFH - git-log variant that _does_ search through diffs Eric Raible
2009-06-30  4:03 ` Jeff King
2009-06-30  8:09   ` Junio C Hamano
2009-06-30 18:06     ` Eric Raible
2009-06-30 18:05   ` Eric Raible
2009-06-30 19:31     ` Jeff King
2009-06-30 21:22       ` Eric Raible
2009-06-30 21:34         ` Eric Raible
2009-07-01  7:02         ` Jeff King
2009-07-01  7:26           ` Jeff King [this message]
2009-07-01  7:26           ` [RFC/PATCH 2/2] fix missing NUL termination with pretty=tformat Jeff King
2009-07-01  8:27             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090701072628.GA8101@sigio.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=raible@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).