From: Johannes Sixt <j6t@kdbg.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 4/7] run_command: report system call errors instead of returning error codes
Date: Sun, 5 Jul 2009 21:01:13 +0200 [thread overview]
Message-ID: <200907052101.13741.j6t@kdbg.org> (raw)
In-Reply-To: <ea2d8110ea70b8698bb3674ca4482db64053d841.1246734159.git.j6t@kdbg.org>
On Samstag, 4. Juli 2009, Johannes Sixt wrote:
> + if (status >= 0 || errno != ENOENT)
> + exit(status & 0xff);
With my replacement patch 1/7 this '& 0xff' is no longer necessary. Would you
kindly squash this in?
-- Hannes
diff --git a/git.c b/git.c
--- a/git.c
+++ b/git.c
@@ -418,7 +418,7 @@ static void execv_dashed_external(const char **argv)
*/
status = run_command_v_opt(argv, RUN_SILENT_EXEC_FAILURE);
if (status >= 0 || errno != ENOENT)
- exit(status & 0xff);
+ exit(status);
argv[0] = tmp;
next prev parent reply other threads:[~2009-07-05 19:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-04 19:26 [PATCH 0/7] rework run_command error reporting Johannes Sixt
2009-07-04 19:26 ` [PATCH 1/7] Truncate result of run_command that is used in exit() to lowest 8 bits Johannes Sixt
2009-07-04 19:26 ` [PATCH 2/7] MinGW: simplify waitpid() emulation macros Johannes Sixt
2009-07-04 19:26 ` [PATCH 3/7] run_command: return exit code as positive value Johannes Sixt
2009-07-04 19:26 ` [PATCH 4/7] run_command: report system call errors instead of returning error codes Johannes Sixt
2009-07-04 19:26 ` [PATCH 5/7] run_command: encode deadly signal number in the return value Johannes Sixt
2009-07-04 19:26 ` [PATCH 6/7] run_command: report failure to execute the program, but optionally don't Johannes Sixt
2009-07-04 19:26 ` [PATCH/RFC 7/7] receive-pack: remove unnecessary run_status report Johannes Sixt
2009-07-05 19:01 ` Johannes Sixt [this message]
2009-07-05 19:14 ` [PATCH 4/7] run_command: report system call errors instead of returning error codes Junio C Hamano
2009-07-06 7:37 ` Johannes Sixt
2009-07-05 18:57 ` [Replacement PATCH 1/7] MinGW: truncate exit()'s argument to lowest 8 bits Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907052101.13741.j6t@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).