git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Jackson <ben@ben.com>
To: Eric Wong <normalperson@yhbt.net>
Cc: Yann Dirson <ydirson@linagora.com>,
	git@vger.kernel.org, Ben Jackson <ben@ben.com>
Subject: Re: "git svn reset" only resets current branch ?
Date: Mon, 6 Jul 2009 14:56:20 -0700	[thread overview]
Message-ID: <20090706215619.GA38984@kronos.home.ben.com> (raw)
In-Reply-To: <20090706212928.GA11043@dcvr.yhbt.net>

On Mon, Jul 06, 2009 at 02:29:28PM -0700, Eric Wong wrote:
> Yann Dirson <ydirson@linagora.com> wrote:
> > I just tried the new "git svn reset" from master, and got puzzled that
> > only the svn branch which is an ancestor of current git HEAD got rolled
> > back.  Is that the expected behaviour ?  It would not make it very easy to
> > fixup imports from svn trees with lots of branches/tags.
> 
> Ben was the original implementer of this idea, so I'm not sure of his
> reasoning behind it.  For one, it's easier to only roll back one svn
> branch.  Perhaps adding an --all flag to this command would be the best
> way to go?

The only SVN repos I use git-svn with are either too huge and complex to
fully import with git (up to r135000 at work) or too small to have any
branches (all the various open source projects I've git-svn cloned).  So
the main reason it works that way is that I've never really used git-svn
with branches.

Eric,

Do you expect that it would work to reset one branch and re-fetch it
without touching the other branches?  If not, it would probably imply:

Should cmd_reset always loop over all remotes like cmd_multi_fetch?

As the "opposite of fetch" should it take '--all' and conditionally
loop?

Yann,

It would help if you made a test case (or extended t9139-git-svn-reset.sh)
that illustrated the problem and the desired behavior.

-- 
Ben Jackson AD7GD
<ben@ben.com>
http://www.ben.com/

  reply	other threads:[~2009-07-06 21:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-06 10:07 "git svn reset" only resets current branch ? Yann Dirson
2009-07-06 21:29 ` Eric Wong
2009-07-06 21:56   ` Ben Jackson [this message]
2009-07-06 22:14     ` Eric Wong
  -- strict thread matches above, loose matches on Subject: below --
2009-07-07  8:01 Yann Dirson
2009-07-07 18:21 ` Ben Jackson
2009-07-07 20:28 ` Eric Wong
2009-07-08 15:41 Yann Dirson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090706215619.GA38984@kronos.home.ben.com \
    --to=ben@ben.com \
    --cc=git@vger.kernel.org \
    --cc=normalperson@yhbt.net \
    --cc=ydirson@linagora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).