git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Jackson <ben@ben.com>
To: Yann Dirson <ydirson@linagora.com>
Cc: Eric Wong <normalperson@yhbt.net>, Ben Jackson <ben@ben.com>,
	git@vger.kernel.org
Subject: Re: "git svn reset" only resets current branch ?
Date: Tue, 7 Jul 2009 11:21:11 -0700	[thread overview]
Message-ID: <20090707182109.GA3158@kronos.home.ben.com> (raw)
In-Reply-To: <46974.10.0.0.1.1246953668.squirrel@intranet.linagora.com>

On Tue, Jul 07, 2009 at 10:01:08AM +0200, Yann Dirson wrote:
> 
> As an alternative, we could also allow "git svn reset" to take us back
> into the future to undo any such mistake without refetching.

You can't do that directly, since data is destroyed (specifically, the
rev_map is truncated back to the selected revision).  However, you can
"git reset" the branch back to where it was using the reflog, and then
the next git-svn command you run will rebuild the rev_map from the
comment metadata (obviously you're out of luck if you set "no_metadata").

It's possible that "git-svn reset" should be saving something like
ORIG_HEAD (comments welcome) but that does conflict with the idea of
adding "--all" or defaulting to "--all" behavior.

> I'm not sure it would be the best to keep reset act on a single branch,
> where eg. fetch acts on all branches, and already has a --all flag, which
> is not yet documented, and seems to have a different meaning (if that
> wasn't obvious, I have still not had a look at what it really does ;)

Right, I don't really grok the branch thing on the fetch side either.
I was hoping for guidance from people who use it on what the expected
behavior is.  I see even branch users are fuzzy.  ;-)

The one area where I can definitely see a potential problem is if you
reset/refetched one branch (and the revs actually changed, eg due to
permissions changes or --ignore-paths changes) and then did a merge.
On the other hand, the documentation already suggests you not try to
do SVN branch merges with git-svn.

-- 
Ben Jackson AD7GD
<ben@ben.com>
http://www.ben.com/

  reply	other threads:[~2009-07-07 18:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-07  8:01 "git svn reset" only resets current branch ? Yann Dirson
2009-07-07 18:21 ` Ben Jackson [this message]
2009-07-07 20:28 ` Eric Wong
  -- strict thread matches above, loose matches on Subject: below --
2009-07-08 15:41 Yann Dirson
2009-07-06 10:07 Yann Dirson
2009-07-06 21:29 ` Eric Wong
2009-07-06 21:56   ` Ben Jackson
2009-07-06 22:14     ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090707182109.GA3158@kronos.home.ben.com \
    --to=ben@ben.com \
    --cc=git@vger.kernel.org \
    --cc=normalperson@yhbt.net \
    --cc=ydirson@linagora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).