git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Junio C Hamano <gitster@pobox.com>,
	Git Mailing List <git@vger.kernel.org>,
	Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Subject: Re: gitweb: buggy 'commitdiff_plain' output
Date: Fri, 10 Jul 2009 23:50:13 +0200	[thread overview]
Message-ID: <200907102350.15511.jnareb@gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.01.0907101405480.3352@localhost.localdomain>

On Fri, 10 July 2009, Linus Torvalds wrote:
> On Fri, 10 Jul 2009, Jakub Narebski wrote:
>> On Fri, 10 July 2009, Linus Torvalds wrote:
>>> 
>>> It turns out that that duplication is because they use gitweb as a strange 
>>> patch distribution system (rather than emailing each other patches), and 
>>> download the 'commitdiff_plain' version of the diff and then apply it with 
>>> 'git am -s'.
>> 
>> First question: do they use gitweb from git.git repository, or a custom
>> fork of gitweb (like git.kernel.org gitweb, which has caching, but IIRC
>> does not have all new gitweb features)?
> 
> I have no idea. Afaik, it was on samba.org:
> 
> 	http://git.samba.org/?p=jlayton/cifs.git;a=commitdiff_plain;h=acc11a88a4cb4ba16777099da00664347e0683f0
> 
> and I have no clue whether samba org uses plain git gitweb or something 
> fancier.

Thanks. It looks on first glance like ordinary gitweb, only old.  It is
git and gitweb version 1.5.4.3 from 23 Feb 2008, while Giuseppe's patches
made it into git in v1.6.1 or v1.6.2 (commit is from 23 Dec 2008).

-- 
Jakub Narebski
Poland

  reply	other threads:[~2009-07-10 21:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-10 17:04 gitweb: buggy 'commitdiff_plain' output Linus Torvalds
2009-07-10 17:33 ` Jakub Narebski
2009-07-10 17:38   ` Giuseppe Bilotta
2009-07-10 21:05   ` Linus Torvalds
2009-07-10 21:50     ` Jakub Narebski [this message]
2009-07-10 17:34 ` Giuseppe Bilotta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907102350.15511.jnareb@gmail.com \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=giuseppe.bilotta@gmail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).