git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: [PATCH 0/3] gitweb: 'blame' view improvements
Date: Fri, 10 Jul 2009 23:54:42 +0200	[thread overview]
Message-ID: <200907102354.43232.jnareb@gmail.com> (raw)

This patch series was inspired by the study before sending proposal
for git-blame improvements; I have noticed that "previous"/"parent"
blame header was already implemented, just not documented:
  Subject: git-blame: Documenting "previous" header
  Message-ID: <200907071423.40938.jnareb@gmail.com>
  http://thread.gmane.org/gmane.comp.version-control.git/122837

Therefore proposal got cut down to tree blame:
  Subject: [RFC] Tree blame (git blame <directory>)
  Message-ID: <200907071058.39390.jnareb@gmail.com>
  http://thread.gmane.org/gmane.comp.version-control.git/122830


Using "previous" header should improve gitweb performance and (as
I have noticed during implementing it) allow to follow 'linenr'
links correctly through rename in a blamed commit.

Marking "boundary" somewhat was required to make it possible to
distinguish which 'linenr' links would lead to parent of a blame
commit (to previous version of a file), and which would elad to blamed
commit.  Current styling is up to debate.

After implementing using "previous" header in 'blame' view (which
would allow to do the same for proposed 'blame_incremental' view)
I remembered that last version of implementing 'blame_incremental'
added author initials a'la "git gui blame".  So I did the same for
non-incremental 'blame' view.  Exact formatting is up to debate.

Table of contents:
==================
 [PATCH 1/3] gitweb: Mark boundary commits in 'blame' view
 [PATCH 2/3] gitweb: Use "previous" header of git-blame -p in 'blame' view
 [PATCH 3/3] gitweb: Add author initials in 'blame' view, a la "git gui blame"

Jakub Narebski (3):
  gitweb: Mark boundary commits in 'blame' view
  gitweb: Use "previous" header of git-blame -p in 'blame' view
  gitweb: Add author initials in 'blame' view, a la "git gui blame"


 gitweb/gitweb.css  |    4 ++++
 gitweb/gitweb.perl |   51 ++++++++++++++++++++++++++++++++++++---------------
 2 files changed, 40 insertions(+), 15 deletions(-)

-- 
Jakub Narebski
Poland

             reply	other threads:[~2009-07-10 22:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-10 21:54 Jakub Narebski [this message]
2009-07-10 21:55 ` [PATCH 1/3] gitweb: Mark boundary commits in 'blame' view Jakub Narebski
2009-07-10 21:57 ` [PATCH 2/3] gitweb: Use "previous" header of git-blame -p " Jakub Narebski
2009-07-10 22:21   ` Junio C Hamano
2009-07-11  9:17     ` Jakub Narebski
2009-07-12 17:21   ` Luben Tuikov
2009-07-14 19:21   ` Jakub Narebski
2009-07-10 22:01 ` [PATCH 3/3] gitweb: Add author initials in 'blame' view, a la "git gui blame" Jakub Narebski
2009-07-11 16:56 ` [PATCH 0/3] gitweb: 'blame' view improvements Jakub Narebski
2009-07-13 19:08   ` [RFC PATCH 5/3] gitweb: Incremental blame (proof of concept) Jakub Narebski
2009-07-12 22:08 ` [PATCH 4/3] gitweb: Use light/dark class also in 'blame' view Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907102354.43232.jnareb@gmail.com \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).