From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Cc: Luben Tuikov <ltuikov@yahoo.com>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/3] gitweb: Use "previous" header of git-blame -p in 'blame' view
Date: Tue, 14 Jul 2009 21:21:29 +0200 [thread overview]
Message-ID: <200907142121.31012.jnareb@gmail.com> (raw)
In-Reply-To: <200907102357.43475.jnareb@gmail.com>
On Fri, 10 July 2009, Jakub Narebski wrote:
> +# if filename is surrounded in double quotes, it need to be unquoted
> +sub unquote_maybe {
> + my $str = shift;
> +
> + if ($str =~ /^"(.*)"$/) {
> + return unquote($1);
> + }
> + return $str;
> +}
I'm sorry about that, but this is totally unnecessary, as
unquote == unquote_maybe (unquotes only when necessary).
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2009-07-14 19:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-10 21:54 [PATCH 0/3] gitweb: 'blame' view improvements Jakub Narebski
2009-07-10 21:55 ` [PATCH 1/3] gitweb: Mark boundary commits in 'blame' view Jakub Narebski
2009-07-10 21:57 ` [PATCH 2/3] gitweb: Use "previous" header of git-blame -p " Jakub Narebski
2009-07-10 22:21 ` Junio C Hamano
2009-07-11 9:17 ` Jakub Narebski
2009-07-12 17:21 ` Luben Tuikov
2009-07-14 19:21 ` Jakub Narebski [this message]
2009-07-10 22:01 ` [PATCH 3/3] gitweb: Add author initials in 'blame' view, a la "git gui blame" Jakub Narebski
2009-07-11 16:56 ` [PATCH 0/3] gitweb: 'blame' view improvements Jakub Narebski
2009-07-13 19:08 ` [RFC PATCH 5/3] gitweb: Incremental blame (proof of concept) Jakub Narebski
2009-07-12 22:08 ` [PATCH 4/3] gitweb: Use light/dark class also in 'blame' view Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907142121.31012.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ltuikov@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).