From: Derek Fawcus <dfawcus@cisco.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Nicolas Sebrecht <nicolas.s.dev@gmx.fr>,
git@vger.kernel.org,
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>,
Johannes Sixt <j.sixt@viscovery.net>
Subject: Re: [PATCH v2] git-am: fix maildir support regression for unordered headers in emails
Date: Wed, 15 Jul 2009 13:54:19 +0100 [thread overview]
Message-ID: <20090715125419.GA21811@gpk-lds-007.cisco.com> (raw)
In-Reply-To: <7vljmqflti.fsf@alter.siamese.dyndns.org>
On Wed, Jul 15, 2009 at 12:27:05AM -0700, Junio C Hamano wrote:
> Nicolas Sebrecht <nicolas.s.dev@gmx.fr> writes:
>
> > Patch format detection introduced by a5a6755a1d4707bf2fab7752e5c974ebf63d086a
> > may refuse valid patches from verbatim emails.
>
> It is unclear what you meant by "verbatim email". A verbatim e-mail
> in mbox begins with "From " header that is already covered in the existing
> code long before support for stgit/hg was added.
I believe he is referring to the claimed support for maildir format boxes.
> But I am not convinced that I understand what _problem_ you are trying to
> solve in the first place.
Assuming it is maildir support, then there is no 'header' as such in the
file which can be detected. One could try and detect that the contents
are structured as an RFC822 message (but with local line ends), or one
could try and detect that the file is within a maildir folder.
It seems this patch is taking the former approach and trying to ensure
the file consists of header fields.
next prev parent reply other threads:[~2009-07-15 13:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-14 6:40 [PATCH] git-am: less strong format "mbox" detection Nicolas Sebrecht
2009-07-14 7:16 ` Giuseppe Bilotta
2009-07-14 8:20 ` [PATCH] " Nicolas Sebrecht
2009-07-14 8:35 ` Johannes Sixt
2009-07-14 8:42 ` Junio C Hamano
2009-07-14 12:23 ` Nicolas Sebrecht
2009-07-15 5:52 ` [PATCH v2] git-am: fix maildir support regression for unordered headers in emails Nicolas Sebrecht
2009-07-15 7:27 ` Junio C Hamano
2009-07-15 12:54 ` Derek Fawcus [this message]
2009-07-15 16:19 ` [PATCH v2] " Nicolas Sebrecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090715125419.GA21811@gpk-lds-007.cisco.com \
--to=dfawcus@cisco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=giuseppe.bilotta@gmail.com \
--cc=j.sixt@viscovery.net \
--cc=nicolas.s.dev@gmx.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).