From: Nicolas Sebrecht <nicolas.s.dev@gmx.fr>
To: Nicolas Sebrecht <nicolas.s.dev@gmx.fr>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org,
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Subject: [PATCH v3] Re: git-am: fix maildir support regression: accept email file as patch
Date: Thu, 16 Jul 2009 04:06:32 +0200 [thread overview]
Message-ID: <20090716020632.GD12971@vidovic> (raw)
In-Reply-To: <20090716010001.GC12971@vidovic>
The 16/07/09, Nicolas Sebrecht wrote:
> It is not about adding a new feature. It's about keeping compatibility
> with maildir. The current version _rejects_ good patches.
>
> But, as it's very easy to move emails from a maildir _or_ have a symlink
> which links to "maildir/cur" or whatever, we really should rely on the
> content of the files.
Hum, it's not true.
Symlink as parameter didn't work before. So, it breaks things like:
$ git am symlink/*
$ git am directory/{anything relying on shell globbing}
$ git am patch1 patch2
This was traditionally permitted even if git-am was not designed to. I
wonder if we should add this feature as it could break end-user
workflows.
--
Nicolas Sebrecht
next prev parent reply other threads:[~2009-07-16 2:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-15 22:19 [PATCH v3] git-am: fix maildir support regression: accept email file as patch Nicolas Sebrecht
2009-07-15 22:43 ` [PATCH v3] " Nicolas Sebrecht
2009-07-15 22:54 ` [PATCH v3] " Junio C Hamano
2009-07-15 23:56 ` Junio C Hamano
2009-07-16 1:00 ` [PATCH v3] " Nicolas Sebrecht
2009-07-16 2:06 ` Nicolas Sebrecht [this message]
2009-07-16 2:30 ` Junio C Hamano
2009-07-16 2:59 ` Nicolas Sebrecht
2009-07-16 0:49 ` Nicolas Sebrecht
2009-07-16 2:41 ` Junio C Hamano
2009-07-16 4:05 ` [PATCH v4] git-am: allow e-mail file(s) as input Nicolas Sebrecht
2009-07-16 4:10 ` [PATCH v4] " Nicolas Sebrecht
2009-07-16 5:23 ` [PATCH v5] " Nicolas Sebrecht
2009-07-16 7:09 ` Stephen Boyd
2009-07-16 7:24 ` Junio C Hamano
2009-07-16 7:50 ` [PATCH v5] " Nicolas Sebrecht
2009-07-16 8:06 ` Nicolas Sebrecht
2009-07-16 8:17 ` Johannes Sixt
2009-07-16 8:12 ` Johannes Sixt
2009-07-16 17:45 ` [PATCH v6] mailinfo: allow e-mail files " Nicolas Sebrecht
2009-07-17 1:05 ` Junio C Hamano
2009-07-17 2:20 ` [PATCH v6] " Nicolas Sebrecht
2009-07-17 10:06 ` [PATCH v6] " Nanako Shiraishi
2009-07-17 19:54 ` Junio C Hamano
2009-07-17 22:04 ` [PATCH v6] " Nicolas Sebrecht
2009-08-06 17:07 ` [PATCH v7] " Nicolas Sebrecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090716020632.GD12971@vidovic \
--to=nicolas.s.dev@gmx.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=giuseppe.bilotta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).