From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Yann Simon <yann.simon.fr@gmail.com>, git <git@vger.kernel.org>
Subject: Re: [JGIT PATCH v2] FindBugs: don't use new String(String) in RefDatabase
Date: Tue, 21 Jul 2009 16:50:36 +0200 [thread overview]
Message-ID: <200907211650.36831.robin.rosenberg.lists@dewire.com> (raw)
In-Reply-To: <20090713145308.GI11191@spearce.org>
måndag 13 juli 2009 16:53:08 skrev "Shawn O. Pearce" <spearce@spearce.org>:
> Yann Simon <yann.simon.fr@gmail.com> wrote:
> > This method is quite clear.
> > One line javadoc would make it even clearer... :p (and maybe make Robin happy)
>
> Javadoc is overrated. Private utility methods like this that are one
> line long don't need documentation. The rationale for why this line
> does what it does is something that `git blame` can answer better.
Sorry Yann, I'm with Shawn here. A comment wouldn't add anything here since
the method is pretty simple. Besides javadocs are for API's so an inline comment
would be better, but I don't think it is necessary.
Shawn, any references for the ability of JIT's abilities to stack allocate in this context? For
me learning, will commit anyway.
-- robina
next prev parent reply other threads:[~2009-07-21 14:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-19 9:15 [PATCH JGIT] Method invokes inefficient new String(String) constructor Yann Simon
2009-03-19 16:01 ` Shawn O. Pearce
2009-03-19 16:44 ` Yann Simon
2009-07-09 8:47 ` Yann Simon
2009-07-10 15:34 ` [PATCH] FindBugs: don't use new String(String) in RefDatabase Shawn O. Pearce
2009-07-13 8:07 ` Yann Simon
2009-07-13 14:53 ` [JGIT PATCH v2] " Shawn O. Pearce
2009-07-21 14:50 ` Robin Rosenberg [this message]
2009-07-21 15:03 ` Shawn O. Pearce
2009-07-21 19:47 ` Robin Rosenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907211650.36831.robin.rosenberg.lists@dewire.com \
--to=robin.rosenberg.lists@dewire.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
--cc=yann.simon.fr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).