From: Greg Price <price@ksplice.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Johannes Sixt <j.sixt@viscovery.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: [PATCH v2 0/1] Fix rebase -p --onto
Date: Wed, 22 Jul 2009 12:37:38 -0400 [thread overview]
Message-ID: <20090722163738.GO7503@vinegar-pot.mit.edu> (raw)
I sent a version of the following patch last week to fix the behavior
of rebase -p to respect --onto. Some questions were raised and I
believe I've addressed all of them.
The code already distinguishes the cases Junio described in a natural
way, as demonstrated by a test case in the revised patch. The use
case Hannes described has never worked, as Dscho explained, and in any
case concerns a different part of the code from this patch -- when the
great day comes that rebase -i -p can reorder commits, this patch will
work smoothly with that.
Are there further comments? If not, I believe this is ready for merge.
Greg
next reply other threads:[~2009-07-22 16:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-22 16:37 Greg Price [this message]
2009-07-22 16:38 ` [PATCH v2 1/1] Fix rebase -p --onto Greg Price
2009-07-22 17:07 ` [PATCH v2 0/1] " Johannes Schindelin
2009-07-22 17:36 ` Greg Price
2009-07-22 18:05 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090722163738.GO7503@vinegar-pot.mit.edu \
--to=price@ksplice.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox