From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH/RFC] SunOS grep does not understand -C<n>
Date: Fri, 24 Jul 2009 01:41:45 -0400 [thread overview]
Message-ID: <20090724054144.GC6563@sigill.intra.peff.net> (raw)
In-Reply-To: <7vr5w6tzq8.fsf@alter.siamese.dyndns.org>
On Thu, Jul 23, 2009 at 10:30:07PM -0700, Junio C Hamano wrote:
> I noticed that the first "grep -C1" test in t7002 does not pass on my
> SunOS-5.11-i86pc, and that is not because our way to spawn external
> grep is broken, but because the native grep does not understand -C<n>.
>
> Is it just me and my installation (i.e. I might have failed to install
> saner grep from the distribution that everybody uses), or everybody on
> SunOS is using this option himself because our Makefile doesn't do that
> automatically for them?
>
> Just in case it is the latter, here is a proposed patch.
Yes, I've been building with NO_EXTERNAL_GREP for my test box. The grep
from Solaris 8, at least, doesn't understand '-e' either, which causes
it to fail many other tests.
-Peff
next prev parent reply other threads:[~2009-07-24 5:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-24 5:30 [PATCH/RFC] SunOS grep does not understand -C<n> Junio C Hamano
2009-07-24 5:41 ` Jeff King [this message]
2009-07-24 6:27 ` Junio C Hamano
2009-07-24 7:09 ` Jeff King
2009-07-24 6:29 ` [PATCH/RFC] FreeBSD iconv function signature is "old" Junio C Hamano
2009-12-26 9:09 ` Junio C Hamano
2009-07-24 15:43 ` [PATCH/RFC] SunOS grep does not understand -C<n> Brandon Casey
2009-07-24 15:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090724054144.GC6563@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).