From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Constantine Plotnikov <constantine.plotnikov@gmail.com>,
git@vger.kernel.org
Subject: Re: [JGIT PATCH] Fix WindowCacheGetTest.testCache_TooSmallLimit failures
Date: Sun, 26 Jul 2009 01:25:31 +0200 [thread overview]
Message-ID: <200907260125.32306.robin.rosenberg.lists@dewire.com> (raw)
In-Reply-To: <20090725200056.GD11191@spearce.org>
lördag 25 juli 2009 22:00:56 skrev "Shawn O. Pearce" <spearce@spearce.org>:
> Ever since 2d77d30b5f when I rewrote WindowCache we have been seeing
> random failures inside of the TooSmallLimit test case.
>
> These test failures have been occurring because the cache contained
> more open bytes than it was configured to permit.
>
> The cache was permitted to open more bytes than its configured limit
> because the eviction routine was always skipping the last bucket
> under some conditions. If the cache table was sized the same as its
> evictBatch, which happens for any fairly small table, the eviction
> routine broke too early if it started at a non-zero position in the
> table and wrapped around during its search. By breaking too early
> the routine did not actually perform an eviction, leaving windows
> open it should have closed.
We should have a test for that then.
-- robin
next prev parent reply other threads:[~2009-07-25 23:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <85647ef50907220623i2b7e50dal67650a638921ec0f@mail.gmail.com>
2009-07-24 22:51 ` [JGIT] Re: blinking test WindowCacheGetTest.testCache_TooSmallLimit Shawn O. Pearce
2009-07-25 17:34 ` Robin Rosenberg
2009-07-25 19:42 ` Shawn O. Pearce
2009-07-25 20:00 ` [JGIT PATCH] Fix WindowCacheGetTest.testCache_TooSmallLimit failures Shawn O. Pearce
2009-07-25 23:25 ` Robin Rosenberg [this message]
2009-07-25 23:30 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907260125.32306.robin.rosenberg.lists@dewire.com \
--to=robin.rosenberg.lists@dewire.com \
--cc=constantine.plotnikov@gmail.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).