From mboxrd@z Thu Jan 1 00:00:00 1970 From: Theodore Tso Subject: Re: Performance issue of 'git branch' Date: Sun, 26 Jul 2009 12:29:28 -0400 Message-ID: <20090726162927.GC17272@mit.edu> References: <20090724234648.GA4616@Pilar.aei.mpg.de> <20090725004122.GA28477@Pilar.aei.mpg.de> <20090725215739.d074e947.tihirvon@gmail.com> <20090725203130.GB1640@glandium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Johannes Schindelin , Mike Hommey , Timo Hirvonen , git@vger.kernel.org, "Carlos R. Mafra" , Junio C Hamano To: Linus Torvalds X-From: git-owner@vger.kernel.org Sun Jul 26 18:29:57 2009 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1MV6bk-0005ta-JA for gcvg-git-2@gmane.org; Sun, 26 Jul 2009 18:29:57 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753792AbZGZQ3t (ORCPT ); Sun, 26 Jul 2009 12:29:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753782AbZGZQ3t (ORCPT ); Sun, 26 Jul 2009 12:29:49 -0400 Received: from thunk.org ([69.25.196.29]:50821 "EHLO thunker.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753758AbZGZQ3s (ORCPT ); Sun, 26 Jul 2009 12:29:48 -0400 Received: from root (helo=closure.thunk.org) by thunker.thunk.org with local-esmtp (Exim 4.50 #1 (Debian)) id 1MV6bN-0004i9-37; Sun, 26 Jul 2009 12:29:33 -0400 Received: from tytso by closure.thunk.org with local (Exim 4.69) (envelope-from ) id 1MV6bI-0006bg-2C; Sun, 26 Jul 2009 12:29:28 -0400 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@mit.edu X-SA-Exim-Scanned: No (on thunker.thunk.org); SAEximRunCond expanded to false Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Sat, Jul 25, 2009 at 09:49:41PM -0700, Linus Torvalds wrote: > > But at the same time, last time I benchmarked the different SHA1 > libraries, the openssl one was the fastest. I think it has tuned assembly > language for most architectures. Our regular mozilla-based C code is > perfectly fine, but it doesn't hold a candle to assembler tuning. So maybe git should import the SHA1 code into its own source base? It's not like the SHA1 code changes often, or is likely to have security issues (at least, not buffer overruns; if SHA1 gets thorouhly broken we might have to change algorithms, but that's a different kettle of fish :-). - Ted