git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Frans Pop <elendil@planet.nl>
To: Nicolas Sebrecht <nicolas.s.dev@gmx.fr>
Cc: Thomas Rast <trast@student.ethz.ch>,
	Erik Faye-Lund <kusmabite@googlemail.com>,
	git@vger.kernel.org
Subject: Re: git-send-email generates mail with invalid Message-Id
Date: Tue, 28 Jul 2009 13:13:50 +0200	[thread overview]
Message-ID: <200907281313.51304.elendil@planet.nl> (raw)
In-Reply-To: <20090728104423.GA12947@vidovic>

On Tuesday 28 July 2009, you wrote:
> Erik Faye-Lund wrote:
> > On Tue, Jul 28, 2009 at 4:46 AM, Frans Pop<elendil@planet.nl> wrote:
> > > I assume that this is a configuration issue in the git setup of the
> > > sender, but shouldn't git-send-email refuse to send out messages
> > > with an invalid Message-Id?
>
> Stricly speacking, it is not an invalid Message-Id. RFC 2822 says that
> the Message-Id has to be unique. The right hand side may not contain a
> domain identifier. It is a RECOMMENDED practice (a good one, though).

It also says that (3.6.4):
   The message identifier (msg-id) is similar in syntax to an angle-addr
   construct without the internal CFWS.

And defines:
   message-id      =       "Message-ID:" msg-id CRLF
   msg-id          =       [CFWS] "<" id-left "@" id-right ">" [CFWS]

So, the domain part *is* required (or at least: there has to be a "@"; it 
maybe does not require id-right to be an actual domain, but that's not 
really relevant here).

So, IMO inn2's check is correct.

  reply	other threads:[~2009-07-28 11:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-28  2:46 git-send-email generates mail with invalid Message-Id Frans Pop
2009-07-28  9:17 ` Erik Faye-Lund
2009-07-28  9:27   ` Thomas Rast
2009-07-28  9:51     ` Erik Faye-Lund
2009-07-28 10:03       ` Thomas Rast
2009-07-28 10:44     ` Nicolas Sebrecht
2009-07-28 11:13       ` Frans Pop [this message]
2009-07-28 11:38         ` Nicolas Sebrecht
2009-07-28 11:47           ` Erik Faye-Lund
2009-07-28 12:10             ` Erik Faye-Lund
2009-07-28 15:07               ` Nicolas Sebrecht
2009-07-28 10:14   ` Frans Pop
2009-07-28 10:26     ` Frans Pop

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907281313.51304.elendil@planet.nl \
    --to=elendil@planet.nl \
    --cc=git@vger.kernel.org \
    --cc=kusmabite@googlemail.com \
    --cc=nicolas.s.dev@gmx.fr \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).