From: Nicolas Sebrecht <nicolas.s.dev@gmx.fr>
To: Erik Faye-Lund <kusmabite@googlemail.com>
Cc: Nicolas Sebrecht <nicolas.s.dev@gmx.fr>,
Frans Pop <elendil@planet.nl>,
Thomas Rast <trast@student.ethz.ch>,
git@vger.kernel.org
Subject: Re: git-send-email generates mail with invalid Message-Id
Date: Tue, 28 Jul 2009 17:07:45 +0200 [thread overview]
Message-ID: <20090728150745.GB16168@vidovic> (raw)
In-Reply-To: <40aa078e0907280510s1afee3ddw3a9333620a3c7d7a@mail.gmail.com>
The 28/07/09, Erik Faye-Lund wrote:
>
> Here's an attempt to fix the case when Sys::Hostname::hostname returns
> "" (domains aren't allowed to be empty if I read RFC2822 correctly).
>
> The problem with the previous attempt was that the earlier if assigned
> "user@" to $du_part, so the last if was never entered ($du_part was
> always defined).
Yes, thank you.
> I generally don't write Perl, so people will most likely barf all over
> this one, but at least it should show the concept. It might not even
> work.
Looks ok here.
> I also suspect that it is not needed.
I'm not sure because http://linux.die.net/man/2/gethostname does not
tell either (and POSIX neither).
That said, I tend to think it worth to merge this fix before having a
bug report.
--
Nicolas Sebrecht
next prev parent reply other threads:[~2009-07-28 15:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-28 2:46 git-send-email generates mail with invalid Message-Id Frans Pop
2009-07-28 9:17 ` Erik Faye-Lund
2009-07-28 9:27 ` Thomas Rast
2009-07-28 9:51 ` Erik Faye-Lund
2009-07-28 10:03 ` Thomas Rast
2009-07-28 10:44 ` Nicolas Sebrecht
2009-07-28 11:13 ` Frans Pop
2009-07-28 11:38 ` Nicolas Sebrecht
2009-07-28 11:47 ` Erik Faye-Lund
2009-07-28 12:10 ` Erik Faye-Lund
2009-07-28 15:07 ` Nicolas Sebrecht [this message]
2009-07-28 10:14 ` Frans Pop
2009-07-28 10:26 ` Frans Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090728150745.GB16168@vidovic \
--to=nicolas.s.dev@gmx.fr \
--cc=elendil@planet.nl \
--cc=git@vger.kernel.org \
--cc=kusmabite@googlemail.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).