git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Rast <trast@student.ethz.ch>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	"Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH 1/3] log: Show reflog date with --date=normal
Date: Tue, 28 Jul 2009 15:11:09 +0200	[thread overview]
Message-ID: <200907281511.10010.trast@student.ethz.ch> (raw)
In-Reply-To: <alpine.DEB.1.00.0907281428220.8306@pacific.mpi-cbg.de>

Johannes Schindelin wrote:
> 
> Inspecting reflogs is an interactive task, and I do not think that this 
> justifies the complications you suggested.  I can _easily_ say "git log 
> -g" and then "git show --date=relative <commit>".  Not that I _ever_ 
> needed such a thing.

That's something entirely different.  This series is about the date of
*reflog entries*; the git-show will give you the dates associated with
the *commit*.  The latter act naturally w.r.t. --date and are of no
concern to this discussion (other than not breaking them of course).

The reflog entries, OTOH, show numbers instead in "default" date mode,
leading people to do things like

  git reflog show HEAD@{now}
  git reflog --date=local

to see the reflog with dates instead of numbers.  (AFAICT 'reflog' in
this usage is equivalent to 'log -g --oneline' which is even more
typing, so I'm usually assuming 'reflog'.)

So the discussion on IRC was about making a shorthand like --date that
triggers display of the reflog dates.  This much can be solved by the
DATE_UNSPECIFIED value alone.

I just wasn't happy to leave it at that because that means people who
do set log.date now always get dates instead of numbers in the reflog.

> And what exactly does "--no-date" mean?  Does it not say _exactly_ what 
> "--date=unspecified" would _intuitively_ mean?

Maybe to someone who knows the implementation details.  To a user,
specifying --date=unspecified is probably a contradiction in terms,
and even if not, it does not show the date in some unspecified format
-- it hides it (again, for reflog dates).

-- 
Thomas Rast
trast@{inf,student}.ethz.ch

  reply	other threads:[~2009-07-28 13:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-28  8:40 [PATCH 1/3] log: Show reflog date with --date=normal Thomas Rast
2009-07-28  8:40 ` [PATCH 2/3] log: --date and --no-date to toggle reflog dates Thomas Rast
2009-07-28  8:40 ` [PATCH 3/3] bash completion: log --date, --no-date and --date=normal Thomas Rast
2009-07-28 10:49 ` [PATCH 1/3] log: Show reflog date with --date=normal Johannes Schindelin
2009-07-28 10:51   ` Johannes Schindelin
2009-07-28 11:53   ` Thomas Rast
2009-07-28 12:31     ` Johannes Schindelin
2009-07-28 13:11       ` Thomas Rast [this message]
2009-07-28 13:27         ` Johannes Schindelin
2009-07-28 17:05 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907281511.10010.trast@student.ethz.ch \
    --to=trast@student.ethz.ch \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).