From: Frans Pop <elendil@planet.nl>
To: Nicolas Sebrecht <nicolas.s.dev@gmx.fr>
Cc: git@vger.kernel.org
Subject: Re: Add option in git-am to ignore leading text?
Date: Tue, 28 Jul 2009 19:38:24 +0200 [thread overview]
Message-ID: <200907281938.24960.elendil@planet.nl> (raw)
In-Reply-To: <20090728142219.GA16168@vidovic>
On Tuesday 28 July 2009, Nicolas Sebrecht wrote:
> The 28/07/09, Frans Pop wrote:
> > That's a very useful feature. However, on lkml there are frequently
> > also mails with the following structure (example: [1]).
> >
> > [1] http://lkml.org/lkml/2009/7/10/49
>
> This is an example of what not to do. Content after the '---' won't be
> part of the commit message.
Yes, I'm aware of that (and I omitted such a line from my example for that
reason). But currently that's not really relevant as either with or
without that line one needs to manually fix up things before the desired
result is obtained.
If my feature request is implemented I'll of course make sure to omit the
'---' line if needed.
Here are some other examples (some of which would equally need to drop or
change a separator line).
http://lkml.org/lkml/2009/6/25/62
http://lkml.org/lkml/2009/6/22/114
http://lkml.org/lkml/2009/6/30/109
http://lkml.org/lkml/2009/6/30/224
> IMHO, a better way would be to ignore lines beginning with a defined
> level of quotes in the commit message (the "level" beeing the number of
> '>' or '> ' found at the beginning of a line. Something like
>
> --strip-quotes[=N]
>
> where N is the level of quoted lines to remove (if "=N" is
> not given, assume that the level is 1 and remove all the quotes).
As Mark Brown has already said, that won't solve the issue for an
introduction or comments added by the sender of the mail.
Also, people use all kinds of quoting schemes, not just leading ">".
And I've also seen plenty of cases where quoted lines _were_ a desired
part of a commit log.
Thanks,
FJP
next prev parent reply other threads:[~2009-07-28 17:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-28 3:13 Add option in git-am to ignore leading text? Frans Pop
2009-07-28 14:22 ` Nicolas Sebrecht
2009-07-28 14:31 ` Mark Brown
2009-07-28 17:38 ` Frans Pop [this message]
2009-07-28 18:15 ` Nicolas Sebrecht
2009-07-28 19:11 ` Frans Pop
2009-07-28 19:19 ` Frans Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907281938.24960.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=git@vger.kernel.org \
--cc=nicolas.s.dev@gmx.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).