From: Frans Pop <elendil@planet.nl>
To: Nicolas Sebrecht <nicolas.s.dev@gmx.fr>
Cc: git@vger.kernel.org
Subject: Re: Add option in git-am to ignore leading text?
Date: Tue, 28 Jul 2009 21:11:13 +0200 [thread overview]
Message-ID: <200907282111.14404.elendil@planet.nl> (raw)
In-Reply-To: <20090728181524.GC16168@vidovic>
On Tuesday 28 July 2009, Nicolas Sebrecht wrote:
> > Here are some other examples (some of which would equally need to
> > drop or change a separator line).
> > http://lkml.org/lkml/2009/6/25/62
> Uses "From:", "Date:", and "Subject:".
>
> > http://lkml.org/lkml/2009/6/22/114
> Uses "From:" and "Subject:".
>
> > http://lkml.org/lkml/2009/6/30/109
> Uses "Subject:" only.
>
> I guess there are as results as contributors but it could be possible
> to add some rules to the format. This could ending up with an unuseable
> feature in practice, though. I don't know.
My proposal was "when it encounters _either_ a From: _or_ a Subject:
pseudo header" which would work for all examples. But I fully agree with
you that some rules are needed.
Whether to do the same on Date: is less obvious, but I doubt that would
ever be seen without at least one of the others (and the rules could
specify that).
> > http://lkml.org/lkml/2009/6/30/224
> Broken link ?
Works for me, just slow.
> > And I've also seen plenty of cases where quoted lines _were_ a
> > desired part of a commit log.
>
> Yes, that's why it's an _option_.
IMHO it does not add much. My proposal would be more generic exactly
because it defines the pseudo headers as a natural separator between
introduction and the part of the mail git-am should act on.
next prev parent reply other threads:[~2009-07-28 19:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-28 3:13 Add option in git-am to ignore leading text? Frans Pop
2009-07-28 14:22 ` Nicolas Sebrecht
2009-07-28 14:31 ` Mark Brown
2009-07-28 17:38 ` Frans Pop
2009-07-28 18:15 ` Nicolas Sebrecht
2009-07-28 19:11 ` Frans Pop [this message]
2009-07-28 19:19 ` Frans Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907282111.14404.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=git@vger.kernel.org \
--cc=nicolas.s.dev@gmx.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).