From: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] Allow author names with just two letters.
Date: Wed, 29 Jul 2009 16:55:18 +0200 [thread overview]
Message-ID: <20090729145518.GA8743@troll08.nokia.trolltech.de> (raw)
In-Reply-To: <20090710200134.GA30032@troll08.nokia.trolltech.de>
moin,
just in case this wasn't clear: the patch below is a request to merge,
or at least an rfc. you see, i have a rather bad standing in getting my
colleagues to use rebase if git mangles their commits in the process. ;)
thanks
greetings
On Fri, Jul 10, 2009 at 10:01:34PM +0200, Oswald Buddenhagen wrote:
> Some at Qt Software use aliases which may have only two letters.
>
> One could argue that just one letter should be permitted as well,
> but that's none of my concerns. :)
> ---
> builtin-mailinfo.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/builtin-mailinfo.c b/builtin-mailinfo.c
> index 1eeeb4d..1adbebd 100644
> --- a/builtin-mailinfo.c
> +++ b/builtin-mailinfo.c
> @@ -35,7 +35,7 @@ static void cleanup_space(struct strbuf *sb);
> static void get_sane_name(struct strbuf *out, struct strbuf *name, struct strbuf *email)
> {
> struct strbuf *src = name;
> - if (name->len < 3 || 60 < name->len || strchr(name->buf, '@') ||
> + if (name->len < 2 || 60 < name->len || strchr(name->buf, '@') ||
> strchr(name->buf, '<') || strchr(name->buf, '>'))
> src = email;
> else if (name == out)
> --
> 1.6.3.3.18.g49902.dirty
>
prev parent reply other threads:[~2009-07-29 14:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-10 20:01 [PATCH] Allow author names with just two letters Oswald Buddenhagen
2009-07-29 14:55 ` Oswald Buddenhagen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090729145518.GA8743@troll08.nokia.trolltech.de \
--to=oswald.buddenhagen@nokia.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).