From: Jakub Narebski <jnareb@gmail.com>
To: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Petr Baudis <pasky@suse.cz>
Subject: Re: [PATCH] gitweb: suppress 'Use of uninitialized value' error
Date: Fri, 31 Jul 2009 08:24:41 +0200 [thread overview]
Message-ID: <200907310824.42953.jnareb@gmail.com> (raw)
In-Reply-To: <cb7bb73a0907302306k691b1d4fy85d7b460077bc639@mail.gmail.com>
Giuseppe Bilotta wrote:
> 2009/7/31 Jakub Narebski <jnareb@gmail.com>:
> > I don't think gitweb generates such
> > broken links (with 'hash_parent_base' but not 'file_parent') normally,
> > but I might be mistaken.
>
> Do you think it would be worth to protect against this case?
Yes, of course it is worth protecting against this case (better checking
if both sides of 'eq' comparison are defined). We want to return error
message from gitweb if URL is borked, not have Perl error in logs.
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2009-07-31 6:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-30 21:15 [PATCH] gitweb: suppress 'Use of uninitialized value' error Giuseppe Bilotta
2009-07-30 23:00 ` Jakub Narebski
2009-07-31 6:06 ` Giuseppe Bilotta
2009-07-31 6:24 ` Jakub Narebski [this message]
2009-07-31 6:48 ` [PATCH] gitweb: fix 'Use of uninitialized value' error in href() Giuseppe Bilotta
2009-07-31 8:30 ` Jakub Narebski
2009-07-31 8:37 ` Giuseppe Bilotta
2009-07-31 14:51 ` Junio C Hamano
2009-08-04 7:26 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907310824.42953.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=giuseppe.bilotta@gmail.com \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).