Git development
 help / color / mirror / Atom feed
From: Thomas Rast <trast@student.ethz.ch>
To: Dan McGee <dpmcgee@gmail.com>
Cc: <git@vger.kernel.org>
Subject: Re: blame on a deleted/renamed file
Date: Wed, 5 Aug 2009 15:24:43 +0200	[thread overview]
Message-ID: <200908051524.46502.trast@student.ethz.ch> (raw)
In-Reply-To: <449c10960908050516k25ef0a92sd8616de29a93ea5f@mail.gmail.com>

Dan McGee wrote:
> 
> This is the first thing I have seen svn be able to do[1] that git
> can't. :)
> 
> [1] svn annotate http://path/to/repo/path/to/file@2345

The only thing broken is git-annotate's guessing code to see if you
use the 'git annotate <file> <revision>' (legacy) or 'git annotate
<revision> <file>' syntax.

I'd simply write the unambiguous

  git blame e19d7da4~1 -- "scripts/makepkg.in"

and similarly for other revisions.  And you'll immediately notice that
git *can* do this.

> OK, it did a move of a bunch of lines into functions that GIT couldn't
> quite track:

You can try

  git blame -C -C scripts/makepkg.sh.in

to let git try *really* hard to find out where the lines come from.
Note that it does find some lines from older commits, e.g.,

  2ef1c841 scripts/makepkg.in    (Dag Odenhall                2007-05-30 23:04:36 +0200  470)

in the body of download_sources, which was moved (but apparently not
changed) in e19d7da4 (Andrew Fyfe, 2007-06-01 22:10:27 +0100).

-- 
Thomas Rast
trast@{inf,student}.ethz.ch

  parent reply	other threads:[~2009-08-05 13:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-05 12:16 blame on a deleted/renamed file Dan McGee
2009-08-05 12:37 ` Björn Steinbrink
2009-08-05 12:54   ` Matthieu Moy
2009-08-05 13:54   ` Dan McGee
2009-08-05 14:09     ` Björn Steinbrink
     [not found]       ` <449c10960908050849pa4df6c6x3f5aa4510e9a2642@mail.gmail.com>
2009-08-05 16:56         ` Björn Steinbrink
2009-08-05 13:24 ` Thomas Rast [this message]
2009-08-05 17:25 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200908051524.46502.trast@student.ethz.ch \
    --to=trast@student.ethz.ch \
    --cc=dpmcgee@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox