Git development
 help / color / mirror / Atom feed
From: Emmanuel Trillaud <etrillaud@gmail.com>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 4/9] add missing long option to 'git grep' bash competion
Date: Sat, 8 Aug 2009 22:07:39 +0200	[thread overview]
Message-ID: <20090808220739.663bb1f7@eleanor> (raw)
In-Reply-To: <7vskg2dr3o.fsf@alter.siamese.dyndns.org>

> > according to the 'git-grep' man page, the following long options are
> > missing from the 'git grep' bash completion :
> > --null
> > --color
> > --no-color
> 
> I do not think completion's purpose should be to offer everything
> available under the sun, so "according to manpage these are missing" can
> never be a good justification for patches in this series.
When I saw that completion for the long options of 'git checkout' was
mising, I just start looking around the docs to see if there wasn't other
git commands with some missing completions. I see now it was a wrong way
to update the git bash completion. I will soon come back with a new set
of (more reasonnable) patches.

Emmanuel 

      reply	other threads:[~2009-08-08 20:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-08  8:56 [PATCH 4/9] add missing long option to 'git grep' bash competion Emmanuel Trillaud
2009-08-08 19:48 ` Junio C Hamano
2009-08-08 20:07   ` Emmanuel Trillaud [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090808220739.663bb1f7@eleanor \
    --to=etrillaud@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox