From: Emmanuel Trillaud <etrillaud@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 6/9] update 'git-rm' bash completion according to the man page
Date: Sat, 8 Aug 2009 22:33:12 +0200 [thread overview]
Message-ID: <20090808223312.75ba3d10@eleanor> (raw)
In-Reply-To: <7vljludr2d.fsf@alter.siamese.dyndns.org>
> > - __gitcomp "--cached --dry-run --ignore-unmatch
> > --quiet"
> > + __gitcomp "--force --cached --dry-run
> > --ignore-unmatch --quiet"
>
> I thought not completing --force to allow a dangerous operation was a
> conscious decision.
For me, completion as always been a reminder for options I forgot (or I
think they exist) and I use short options when I know them because it is
easier to type. So IMHO '--force' is a useful option that deserve to be
complete.
But if you make a conscious decision in the past to not complete
'--force', I won't fight :-) and I will just add a comment in the
git-completion script for the guys like me who think it is missing.
Best regard
Emmanuel
prev parent reply other threads:[~2009-08-08 20:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-08 8:56 [PATCH 6/9] update 'git-rm' bash completion according to the man page Emmanuel Trillaud
2009-08-08 19:49 ` Junio C Hamano
2009-08-08 20:33 ` Emmanuel Trillaud [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090808223312.75ba3d10@eleanor \
--to=etrillaud@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).