[PATCH 6/9] update 'git-rm' bash completion according to the man page

[PATCH 6/9] update 'git-rm' bash completion according to the man page

[Emmanuel Trillaud]

Signed-off-by: Emmanuel Trillaud <etrillaud@gmail.com>
---
 contrib/completion/git-completion.bash |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/contrib/completion/git-completion.bash
b/contrib/completion/git-completion.bash
index 98e1185..4746eee 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1828,7 +1828,7 @@ _git_rm ()
 	local cur="${COMP_WORDS[COMP_CWORD]}"
 	case "$cur" in
 	--*)
-		__gitcomp "--cached --dry-run --ignore-unmatch --quiet"
+		__gitcomp "--force --cached --dry-run --ignore-unmatch --quiet"
 		return
 		;;
 	esac
-- 
1.6.4

Re: [PATCH 6/9] update 'git-rm' bash completion according to the man page

[Junio C Hamano]

Emmanuel Trillaud <etrillaud@gmail.com> writes:

> Signed-off-by: Emmanuel Trillaud <etrillaud@gmail.com>

Description of what you did?

> -		__gitcomp "--cached --dry-run --ignore-unmatch --quiet"
> +		__gitcomp "--force --cached --dry-run --ignore-unmatch --quiet"

I thought not completing --force to allow a dangerous operation was a
conscious decision.

Re: [PATCH 6/9] update 'git-rm' bash completion according to the man page

[Emmanuel Trillaud]

> > -		__gitcomp "--cached --dry-run --ignore-unmatch
> > --quiet"
> > +		__gitcomp "--force --cached --dry-run
> > --ignore-unmatch --quiet"
> 
> I thought not completing --force to allow a dangerous operation was a
> conscious decision.
For me, completion as always been a reminder for options I forgot (or I
think they exist) and I use short options when I know them because it is
easier to type. So IMHO '--force' is a useful option that deserve to be
complete. 

But if you make a conscious decision in the past to not complete
'--force', I won't fight :-) and I will just add a comment in the
git-completion script for the guys like me who think it is missing.

Best regard 

Emmanuel