From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3 2/8] wt-status: move many global settings to wt_status structure
Date: Mon, 10 Aug 2009 05:10:10 -0400 [thread overview]
Message-ID: <20090810091010.GA7513@coredump.intra.peff.net> (raw)
In-Reply-To: <1249894465-11018-3-git-send-email-gitster@pobox.com>
On Mon, Aug 10, 2009 at 01:54:19AM -0700, Junio C Hamano wrote:
> --- a/wt-status.h
> +++ b/wt-status.h
> [...]
> @@ -33,8 +32,12 @@ struct wt_status {
> const char *reference;
> int verbose;
> int amend;
> - int untracked;
> int nowarn;
> + int wt_status_use_color;
> + int wt_status_relative_paths;
> + int wt_status_submodule_summary;
> + enum untracked_status_type show_untracked_files;
> +
Is there a particular reason to use such enormous struct member names?
IOW, inside wt_status, why not just "use_color"?
Other than that, I think this is a very positive change (and in fact, I
like the way this whole series is shaping up).
-Peff
prev parent reply other threads:[~2009-08-10 9:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-10 8:54 [PATCH v3 0/8] shortstatus updates Junio C Hamano
2009-08-10 8:54 ` [PATCH v3 1/8] commit: --dry-run Junio C Hamano
2009-08-10 8:54 ` [PATCH v3 2/8] wt-status: move many global settings to wt_status structure Junio C Hamano
2009-08-10 8:54 ` [PATCH v3 3/8] wt-status: move wt_status_colors[] into " Junio C Hamano
2009-08-10 8:54 ` [PATCH v3 4/8] Make git_status_config() file scope static to builtin-commit.c Junio C Hamano
2009-08-10 8:54 ` [PATCH v3 5/8] wt-status: collect untracked files in a separate "collect" phase Junio C Hamano
2009-08-10 8:54 ` [PATCH v3 6/8] git stat: the beginning Junio C Hamano
2009-08-10 8:54 ` [PATCH v3 7/8] git stat: pathspec limits, unlike traditional "git status" Junio C Hamano
2009-08-10 8:54 ` [PATCH v3 8/8] git stat -s: short status output Junio C Hamano
2009-08-10 9:12 ` [PATCH v3 3/8] wt-status: move wt_status_colors[] into wt_status structure Jeff King
2009-08-10 9:10 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090810091010.GA7513@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).