From: "Shawn O. Pearce" <spearce@spearce.org>
To: Tobia Conforto <tobia.conforto@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Droppable Git Gui in Mac OS X
Date: Mon, 10 Aug 2009 08:26:11 -0700 [thread overview]
Message-ID: <20090810152611.GR1033@spearce.org> (raw)
In-Reply-To: <loom.20090807T090458-788@post.gmane.org>
Tobia Conforto <tobia.conforto@gmail.com> wrote:
> I noticed that Git Gui cannot be launched on an existing repository by
> simply dragging the repository folder onto Git Gui's icon in the dock,
> but this is a standard UI feature in OS X.
>
> Here is a fix "Git Gui.app" (which MacPorts installs in
> /opt/local/share/git-gui/lib) to enable this feature.
Interesting.
Two comments:
1) Commit message? What should we record in the project history
for this change?
2) Signed-off-by line? Please see git.git's SUBMITTING_PATCHES
file for details of what this means, and why it is necessary:
http://repo.or.cz/w/alt-git.git?a=blob;f=Documentation/SubmittingPatches;hb=HEAD
> --- Git Gui.app/Contents/Info.plist
> +++ Git Gui.app/Contents/Info.plist
> @@ -24,5 +24,16 @@
> <string>GITg</string>
> <key>CFBundleVersion</key>
> <string>0.12.0</string>
> + <key>CFBundleDocumentTypes</key>
> + <array>
> + <dict>
> + <key>CFBundleTypeOSTypes</key>
> + <array>
> + <string>fold</string>
> + </array>
> + <key>CFBundleTypeRole</key>
> + <string>Viewer</string>
> + </dict>
> + </array>
> </dict>
> </plist>
> --- Git Gui.app/Contents/Resources/Scripts/AppMain.tcl
> +++ Git Gui.app/Contents/Resources/Scripts/AppMain.tcl
> @@ -19,4 +19,9 @@
>
> unset gitexecdir gitguilib
> set argv [lrange $argv 1 end]
> -source $AppMain_source
> +
> +proc ::tk::mac::OpenDocument {args} {
> + cd [lindex $args 0]
> +}
> +
> +after 1 { source $AppMain_source }
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Shawn.
prev parent reply other threads:[~2009-08-10 15:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-07 10:12 Droppable Git Gui in Mac OS X Tobia Conforto
2009-08-10 15:26 ` Shawn O. Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090810152611.GR1033@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=tobia.conforto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).