From: "Shawn O. Pearce" <spearce@spearce.org>
To: Alex Blewitt <alex.blewitt@gmail.com>
Cc: "robin.rosenberg@dewire.com" <robin.rosenberg@dewire.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [EGIT PATCH] Provide a more JavaBeans-style 'getName' accessor for the id Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
Date: Mon, 10 Aug 2009 13:59:07 -0700 [thread overview]
Message-ID: <20090810205907.GY1033@spearce.org> (raw)
In-Reply-To: <E861EAC5-150C-4CF8-AD0F-EBF15CEAE114@gmail.com>
Alex Blewitt <alex.blewitt@gmail.com> wrote:
> That patch was originally mailed on the 11th May. Has it taken until now
> to notice the problem, or was the other method added in the last month or
> so? If I'm to blame, I apologise but didn't note any compile time issues
> at the time.
Arrgh, you are right, I lost this patch in my inbox, and in the
interm we applied new features to RevTag which added getName there.
> On 10 Aug 2009, at 16:52, "Shawn O. Pearce" <spearce@spearce.org> wrote:
>> Obviously you didn't compile test this in JGit:
Never mind.
>> ./org/spearce/jgit/revwalk/RevTag.java:206: getName() in
>> org.spearce.jgit.revwalk.RevTag cannot override getName() in
>> org.spearce.jgit.lib.AnyObjectId; overridden method is final
I can't apply this patch because getName() on RevTag is already
defined with a different meaning. :-(
--
Shawn.
next prev parent reply other threads:[~2009-08-10 20:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-09 22:57 [EGIT PATCH] Provide a more JavaBeans-style 'getName' accessor for the id Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com> Alex Blewitt
2009-05-10 21:19 ` Shawn O. Pearce
2009-08-10 15:52 ` Shawn O. Pearce
2009-08-10 18:11 ` Alex Blewitt
2009-08-10 18:19 ` Alex Blewitt
2009-08-10 20:59 ` Shawn O. Pearce [this message]
2009-08-11 12:53 ` Alex Blewitt
2009-08-12 14:20 ` Shawn O. Pearce
2009-08-12 19:09 ` Robin Rosenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090810205907.GY1033@spearce.org \
--to=spearce@spearce.org \
--cc=alex.blewitt@gmail.com \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).