From: "Shawn O. Pearce" <spearce@spearce.org>
To: Dan Zwell <dzwell@zwell.net>
Cc: Git Mailing List <git@vger.kernel.org>, raa.lkml@gmail.com
Subject: Re: [PATCH] Limit git-gui to display a maximum number of files
Date: Tue, 11 Aug 2009 13:29:27 -0700 [thread overview]
Message-ID: <20090811202927.GZ1033@spearce.org> (raw)
In-Reply-To: <4A81B738.7090507@zwell.net>
Dan Zwell <dzwell@zwell.net> wrote:
> When there is a large number of new or modified files,
> "display_all_files" takes a long time, and git-gui appears to
> hang. This change limits the number of files that are displayed.
> This limit can be set as gui.maxfilesdisplayed, and is
> 5000 by default.
>
> A warning is shown when the list of files is truncated.
>
> Signed-off-by: Dan Zwell <dzwell@zwell.net>
> ---
> By the way, is the right way to deal with strings to be
> translated? See the end of the patch.
No.
> + set warning "Displaying only $display_limit of "
> + append warning "[llength $to_display] files."
> + info_popup [mc $warning]
This should be:
info_popup [mc "Displaying only %s of %s files." $display_limit [llength $to_display]]
> +msgid "Displaying only %s of %s files."
> +msgstr ""
So that then the placeholders are available here...
--
Shawn.
next prev parent reply other threads:[~2009-08-11 20:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-30 20:37 [PATCH] Limited git-gui to displaying 5000 new files Dan Zwell
2009-08-10 15:38 ` Shawn O. Pearce
2009-08-10 17:06 ` Alex Riesen
2009-08-10 17:08 ` Shawn O. Pearce
2009-08-10 15:15 ` Dan Zwell
2009-08-11 18:23 ` [PATCH] Limit git-gui to display a maximum number of files Dan Zwell
2009-08-11 20:29 ` Shawn O. Pearce [this message]
2009-08-11 18:50 ` Dan Zwell
2009-08-12 14:43 ` Shawn O. Pearce
2009-08-12 15:24 ` [PATCH] git-gui: Update russian translation Alex Riesen
2009-08-12 15:40 ` Shawn O. Pearce
2009-08-12 15:51 ` Dan Zwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090811202927.GZ1033@spearce.org \
--to=spearce@spearce.org \
--cc=dzwell@zwell.net \
--cc=git@vger.kernel.org \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).