From: "Shawn O. Pearce" <spearce@spearce.org>
To: Alex Blewitt <alex.blewitt@gmail.com>
Cc: "robin.rosenberg@dewire.com" <robin.rosenberg@dewire.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [EGIT PATCH] Provide a more JavaBeans-style 'getName' accessor for the id Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
Date: Wed, 12 Aug 2009 07:20:49 -0700 [thread overview]
Message-ID: <20090812142049.GA1033@spearce.org> (raw)
In-Reply-To: <8ACC6C83-75FD-477C-9083-96CA426FC069@gmail.com>
Alex Blewitt <alex.blewitt@gmail.com> wrote:
> On 10 Aug 2009, at 21:59, "Shawn O." <spearce@spearce.org> wrote:
>>
>>>> ./org/spearce/jgit/revwalk/RevTag.java:206: getName() in
>>>> org.spearce.jgit.revwalk.RevTag cannot override getName() in
>>>> org.spearce.jgit.lib.AnyObjectId; overridden method is final
>>
>> I can't apply this patch because getName() on RevTag is already
>> defined with a different meaning. :-(
>
> That sounds dangerous. We now have a .name() and a .getName() with
> different semantics. Can we not change the RevTag method name to
> something else so that we dont have an inconsistency?
Good point. We didn't think that RevTag.getName method through
very well. Rename it to getTagName() ?
--
Shawn.
next prev parent reply other threads:[~2009-08-12 14:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-09 22:57 [EGIT PATCH] Provide a more JavaBeans-style 'getName' accessor for the id Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com> Alex Blewitt
2009-05-10 21:19 ` Shawn O. Pearce
2009-08-10 15:52 ` Shawn O. Pearce
2009-08-10 18:11 ` Alex Blewitt
2009-08-10 18:19 ` Alex Blewitt
2009-08-10 20:59 ` Shawn O. Pearce
2009-08-11 12:53 ` Alex Blewitt
2009-08-12 14:20 ` Shawn O. Pearce [this message]
2009-08-12 19:09 ` Robin Rosenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090812142049.GA1033@spearce.org \
--to=spearce@spearce.org \
--cc=alex.blewitt@gmail.com \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).