From: "Luke-Jr" <luke@dashjr.org>
To: Nanako Shiraishi <nanako3@lavabit.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Thomas Rast <trast@student.ethz.ch>,
Luke Dashjr <luke-jr+git@utopios.org>,
git@vger.kernel.org
Subject: Re: [PATCH 1/5] port --ignore-unmatch to "git add"
Date: Fri, 14 Aug 2009 17:54:50 -0500 [thread overview]
Message-ID: <200908141754.51393.luke@dashjr.org> (raw)
In-Reply-To: <20090815063958.6117@nanako3.lavabit.com>
On Friday 14 August 2009 04:39:58 pm Nanako Shiraishi wrote:
> Second of all, if a race condition makes an "add" fail, isn't it a good
> thing? If your "add" ignored such a failure, you'd be recording an
> inconsistent or incomplete state.
If the file doesn't exist, it is no longer in the current state.
> IMHO, fixing your racy script is a much cleaner solution to your problem
> than forcing "git add" to ignore errors.
In this situation, the race condition is not a bug, it is normal operation.
next prev parent reply other threads:[~2009-08-14 22:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-12 22:26 For review: git add --ignore-unmatch Luke-Jr
2009-08-12 22:57 ` Thomas Rast
2009-08-13 3:20 ` [PATCH 1/5] port --ignore-unmatch to "git add" Luke Dashjr
2009-08-13 3:20 ` [PATCH 2/5] fix "git add --ignore-errors" to ignore pathspec errors Luke Dashjr
2009-08-13 3:20 ` [PATCH 3/5] Document --ignore-unmatch in git-add.txt Luke Dashjr
2009-08-13 3:20 ` [PATCH 4/5] implement error_errno and warning_errno Luke Dashjr
2009-08-13 3:20 ` [PATCH 5/5] Convert add_file_to_index's lstat failure from a die to an error Luke Dashjr
2009-08-13 19:38 ` [PATCH 2/5] fix "git add --ignore-errors" to ignore pathspec errors Junio C Hamano
2009-08-13 20:42 ` Luke-Jr
2009-08-13 21:02 ` [PATCH] port --ignore-unmatch to "git add" Luke Dashjr
2009-08-13 21:03 ` [PATCH] Document --ignore-unmatch in git-add.txt Luke Dashjr
2009-08-13 19:36 ` [PATCH 1/5] port --ignore-unmatch to "git add" Junio C Hamano
2009-08-13 20:40 ` Luke-Jr
2009-08-13 21:51 ` Alex Riesen
2009-08-13 21:06 ` Thomas Rast
2009-08-14 19:52 ` Junio C Hamano
2009-08-14 20:39 ` Luke-Jr
2009-08-14 20:47 ` Luke-Jr
2009-08-14 21:39 ` Nanako Shiraishi
2009-08-14 22:54 ` Luke-Jr [this message]
2009-10-10 17:23 ` Luke-Jr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908141754.51393.luke@dashjr.org \
--to=luke@dashjr.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=luke-jr+git@utopios.org \
--cc=nanako3@lavabit.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).