git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Schlichter <thomas.schlichter@web.de>
To: Tay Ray Chuan <rctay89@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	willievu <willievu@dev.java.net>,
	Sean Davis <sdavis2@mail.nih.gov>,
	git@vger.kernel.org
Subject: Re: git http-push and MKCOL error (22/409)
Date: Mon, 17 Aug 2009 19:28:38 +0200	[thread overview]
Message-ID: <200908171928.38999.thomas.schlichter@web.de> (raw)
In-Reply-To: <20090817170943.180dbedd.rctay89@gmail.com>

Hi,

Am Montag 17 August 2009 11:09:43 schrieb Tay Ray Chuan:
> Subject: [PATCH] http.c: don't assume that urls don't end with slash
>
> Make append_remote_object_url() (and by implication,
> get_remote_object_url) use end_url_with_slash() to ensure that the url
> ends with a slash.
>
> Previously, they assumed that the url did not end with a slash and
> as a result appended a slash, sometimes errorneously.
>
> This fixes an issue introduced in 5424bc5 ("http*: add helper methods
> for fetching objects (loose)"), where the append_remote_object_url()
> implementation in http-push.c, which assumed that urls end with a
> slash, was replaced by another one in http.c, which assumed urls did
> not end with a slash.
>
> The above issue was raised by Thomas Schlichter:
>
>   http://marc.info/?l=git&m=125043105231327
>
> Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>

Thank you very much!
This patch indeed fixes my problem.

You may add my

   Tested-by: Thomas Schlichter <thomas.schlichter@web.de>

if you'd like to. I don't know how this is handled in the git-tree...

Is there a plan in which version this patch will be released? Will there be a 
1.6.4.1 or is 1.6.5 next?

Kind regards,
Thomas Schlichter

  reply	other threads:[~2009-08-17 17:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-16 13:57 git http-push and MKCOL error (22/409) Thomas Schlichter
2009-08-16 14:27 ` Tay Ray Chuan
2009-08-16 14:52   ` Thomas Schlichter
2009-08-17  4:52     ` Tay Ray Chuan
2009-08-17  5:18       ` Thomas Schlichter
2009-08-17  5:34         ` Thomas Schlichter
2009-08-16 19:34   ` Junio C Hamano
2009-08-17  4:58     ` Tay Ray Chuan
2009-08-17  5:25       ` Thomas Schlichter
2009-08-17  6:08         ` Junio C Hamano
2009-08-17  9:09         ` Tay Ray Chuan
2009-08-17 17:28           ` Thomas Schlichter [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-09-22 23:51 Sean Davis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200908171928.38999.thomas.schlichter@web.de \
    --to=thomas.schlichter@web.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=rctay89@gmail.com \
    --cc=sdavis2@mail.nih.gov \
    --cc=willievu@dev.java.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).