From: Kirill Smelkov <kirr@mns.spb.ru>
To: Junio C Hamano <gitster@pobox.com>
Cc: Thomas Rast <trast@student.ethz.ch>, Jeff King <peff@peff.net>,
git@vger.kernel.org
Subject: Re: [PATCH] add -p: do not attempt to coalesce mode changes
Date: Tue, 18 Aug 2009 11:52:58 +0400 [thread overview]
Message-ID: <20090818075258.GA4501@tugrik.mns.mnsspb.ru> (raw)
In-Reply-To: <7vtz09lz2r.fsf@alter.siamese.dyndns.org>
On Sat, Aug 15, 2009 at 11:19:24AM -0700, Junio C Hamano wrote:
> Thomas Rast <trast@student.ethz.ch> writes:
>
> > Hmm. I briefly considered worrying about futureproofing, but then
> > decided it wasn't worth it since we also rely on
> > coalesce_overlapping_hunks only being run over the hunks of a single
> > file.
>
> Thanks, all.
Thomas, Jeff, Junio,
Thanks for fixing this!
prev parent reply other threads:[~2009-08-18 7:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-15 12:26 [BUG, PATCH] git add -p: demonstrate failure when staging both mode and hunk Kirill Smelkov
2009-08-15 13:56 ` [PATCH] add -p: do not attempt to coalesce mode changes Thomas Rast
2009-08-15 14:17 ` Jeff King
2009-08-15 14:35 ` Thomas Rast
2009-08-15 18:19 ` Junio C Hamano
2009-08-18 7:52 ` Kirill Smelkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090818075258.GA4501@tugrik.mns.mnsspb.ru \
--to=kirr@mns.spb.ru \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox