git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Lars Hjemli <hjemli@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] git-log: allow --decorate[=short|full]
Date: Tue, 18 Aug 2009 05:33:48 -0400	[thread overview]
Message-ID: <20090818093348.GA3550@coredump.intra.peff.net> (raw)
In-Reply-To: <8c5c35580908150723h6e4c8fcay43b708969a86ae27@mail.gmail.com>

On Sat, Aug 15, 2009 at 04:23:12PM +0200, Lars Hjemli wrote:

> This patch introduces an extension to --decorate to allow the caller to
> specify either the short or the full versions.
> 
> Signed-off-by: Lars Hjemli <hjemli@gmail.com>
> ---
> 
> Thanks for the review. I've adapted the patch to your comments, and
> modified the documentation of '--decorate' to be more specific.

Thanks. Looks good to me.

Acked-by: Jeff King <peff@peff.net>

-Peff

  reply	other threads:[~2009-08-18  9:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-15  9:50 [PATCH] git-log: allow --decorate[=short|full] Lars Hjemli
2009-08-15 10:26 ` Lars Hjemli
2009-08-15 12:28 ` Jeff King
2009-08-15 14:23   ` Lars Hjemli
2009-08-18  9:33     ` Jeff King [this message]
2009-08-18 20:18     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090818093348.GA3550@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=hjemli@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).