From: Jeff King <peff@peff.net>
To: Matthieu Moy <Matthieu.Moy@imag.fr>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 3/3] stash: reject stash name starting with a dash.
Date: Wed, 19 Aug 2009 05:57:16 -0400 [thread overview]
Message-ID: <20090819095716.GA28920@sigill.intra.peff.net> (raw)
In-Reply-To: <vpq8whg1ebi.fsf@bauges.imag.fr>
On Wed, Aug 19, 2009 at 08:57:05AM +0200, Matthieu Moy wrote:
> >> +test_expect_success 'stash --invalid-option' '
> >> + echo bar5 > file &&
> >> + echo bar6 > file2 &&
> >> + git add file2 &&
> >> + ! git stash --invalid-option &&
> >> + test bar5,bar6 = $(cat file),$(cat file2) &&
> >> + git stash -- -message-starting-with-dash &&
> >> + test bar,bar2 = $(cat file),$(cat file2)
> >> +'
> >
> > Should this actually be "git stash save --invalid-option", since it is
> > really testing the actual save option parsing, and not the behavior to
> > automatically push options to "git stash save"?
>
> It could be, but the most annoying DWIM would be the "implicit save"
> case, so that's the one I'm testing. One could test both, but that'd
> probably be a bit overkill.
But if your proposal to accept any "-*' is not accepted, then it is not
testing your added code at all, is it? Even without the rest of the
patch, the test would pass.
-Peff
next prev parent reply other threads:[~2009-08-19 9:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-18 12:46 [RFC PATCH] stash: accept options also when subcommand 'save' is omitted Matthieu Moy
2009-08-18 13:01 ` Matthieu Moy
2009-08-18 17:45 ` Jeff King
2009-08-18 20:20 ` Junio C Hamano
2009-08-18 21:38 ` [PATCH 0/3] short syntaxes for 'git stash' Matthieu Moy
2009-08-18 21:38 ` [PATCH 1/3] stash: accept -k as a shortcut for --keep-index Matthieu Moy
2009-08-18 21:38 ` [PATCH 2/3] stash: accept options also when subcommand 'save' is omitted Matthieu Moy
2009-08-18 21:38 ` [PATCH 3/3] stash: reject stash name starting with a dash Matthieu Moy
2009-08-18 23:35 ` Jeff King
2009-08-18 23:45 ` Junio C Hamano
2009-08-18 23:54 ` Jeff King
2009-08-18 23:55 ` Junio C Hamano
2009-08-19 6:57 ` Matthieu Moy
2009-08-19 9:57 ` Jeff King [this message]
2009-08-18 23:31 ` [PATCH 0/3] short syntaxes for 'git stash' Jeff King
2009-08-18 21:42 ` [RFC PATCH] stash: accept options also when subcommand 'save' is omitted Johannes Schindelin
2009-08-18 21:52 ` Matthieu Moy
2009-08-18 22:37 ` Johannes Schindelin
2009-08-19 7:14 ` Matthieu Moy
2009-08-18 22:30 ` Jeff King
2009-08-18 22:46 ` Johannes Schindelin
2009-08-18 23:06 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090819095716.GA28920@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).