From: Adam Simpkins <simpkins@facebook.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Santi Béjar" <santi@agolina.net>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH] graph API: fix bug in graph_is_interesting()
Date: Wed, 19 Aug 2009 15:55:47 -0700 [thread overview]
Message-ID: <20090819225547.GR8147@facebook.com> (raw)
In-Reply-To: <7v4os41frm.fsf@alter.siamese.dyndns.org>
On Tue, Aug 18, 2009 at 11:25:49PM -0700, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
> >
> > When simplify_commit() logic (now called get_comit_action()) decides to
> > show this commit because revs->show_all was specified, we did not rewrite
> > its parents, but now we will?
>
> That is, here is what I meant...
>
> - if (action == commit_show && revs->prune && revs->dense && want_ancestry(revs)) {
> + if (action == commit_show &&
> + !revs->show_all &&
> + revs->prune && revs->dense && want_ancestry(revs)) {
>
> We may want to add some tests to demonstrate the breakage this fix
> addresses.
Yes, you're right. Thanks for catching that. I'll submit a test case
that checks this scenario.
--
Adam Simpkins
simpkins@facebook.com
next prev parent reply other threads:[~2009-08-19 22:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-18 20:55 interaction between --graph and --simplify-by-decoration Adam Simpkins
2009-08-18 21:18 ` [PATCH] graph API: fix bug in graph_is_interesting() Adam Simpkins
2009-08-18 23:53 ` Junio C Hamano
2009-08-19 2:29 ` Adam Simpkins
2009-08-19 2:34 ` Adam Simpkins
2009-08-19 6:18 ` Junio C Hamano
2009-08-19 6:25 ` Junio C Hamano
2009-08-19 22:55 ` Adam Simpkins [this message]
2009-08-19 22:58 ` [PATCH] Add test case for rev-list --parents --show-all Adam Simpkins
2009-08-20 4:13 ` Junio C Hamano
2009-08-21 18:20 ` [PATCH] Add tests for rev-list --graph with options that simplify history Adam Simpkins
2009-08-21 20:15 ` Junio C Hamano
2009-08-21 21:23 ` Adam Simpkins
2009-08-21 15:39 ` [PATCH] graph API: fix bug in graph_is_interesting() Santi Béjar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090819225547.GR8147@facebook.com \
--to=simpkins@facebook.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=santi@agolina.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).