From: Christian Couder <chriscool@tuxfamily.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Stephan Beyer <s-beyer@gmx.net>,
Daniel Barkalow <barkalow@iabervon.org>,
Jakub Narebski <jnareb@gmail.com>
Subject: [PATCH v2 9/9] rebase -i: use "git sequencer--helper --cherry-pick"
Date: Fri, 21 Aug 2009 07:50:00 +0200 [thread overview]
Message-ID: <20090821055001.3726.52566.chriscool@tuxfamily.org> (raw)
In-Reply-To: <20090821054729.3726.5078.chriscool@tuxfamily.org>
instead of "git cherry-pick", as this will make it easier to
port "git-rebase--interactive.sh" to C.
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
git-rebase--interactive.sh | 11 ++++++++---
1 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
index 7651fd6..349ca50 100755
--- a/git-rebase--interactive.sh
+++ b/git-rebase--interactive.sh
@@ -147,7 +147,8 @@ pick_one () {
pick_one_preserving_merges "$@" && return
if test ! -z "$REBASE_ROOT"
then
- output git cherry-pick "$@"
+ git sequencer--helper --cherry-pick $sha1 \
+ "$GIT_REFLOG_ACTION" "$VERBOSE" $no_ff
return
fi
parent_sha1=$(git rev-parse --verify $sha1^) ||
@@ -157,7 +158,8 @@ pick_one () {
git sequencer--helper --fast-forward $sha1 \
"$GIT_REFLOG_ACTION" "$VERBOSE"
else
- output git cherry-pick "$@"
+ git sequencer--helper --cherry-pick $sha1 \
+ "$GIT_REFLOG_ACTION" "$VERBOSE" $no_ff
fi
}
@@ -269,7 +271,10 @@ pick_one_preserving_merges () {
fi
;;
*)
- output git cherry-pick "$@" ||
+ no_commit=
+ test "a$1" = "a-n" && no_commit=t
+ git sequencer--helper --cherry-pick $sha1 \
+ "$GIT_REFLOG_ACTION" "$VERBOSE" $no_commit ||
die_with_patch $sha1 "Could not pick $sha1"
;;
esac
--
1.6.4.271.ge010d
prev parent reply other threads:[~2009-08-21 5:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-21 5:49 [PATCH v2 0/9] more changes to port rebase -i to C using sequencer code Christian Couder
2009-08-21 5:49 ` [PATCH v2 1/9] sequencer: add "do_fast_forward()" to perform a fast forward Christian Couder
2009-08-21 5:49 ` [PATCH v2 2/9] sequencer: add "--fast-forward" option to "git sequencer--helper" Christian Couder
2009-08-21 5:49 ` [PATCH v2 3/9] sequencer: let "git sequencer--helper" callers set "allow_dirty" Christian Couder
2009-08-21 5:49 ` [PATCH v2 4/9] rebase -i: use "git sequencer--helper --fast-forward" Christian Couder
2009-08-21 5:49 ` [PATCH v2 5/9] revert: libify pick Christian Couder
2009-08-21 7:50 ` Junio C Hamano
2009-08-22 4:35 ` Christian Couder
2009-08-21 5:49 ` [PATCH v2 6/9] pick: libify "pick_help_msg()" Christian Couder
2009-08-21 5:49 ` [PATCH v2 7/9] sequencer: add "do_commit()" and related functions Christian Couder
2009-08-21 5:49 ` [PATCH v2 8/9] sequencer: add "--cherry-pick" option to "git sequencer--helper" Christian Couder
2009-08-21 5:50 ` Christian Couder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090821055001.3726.52566.chriscool@tuxfamily.org \
--to=chriscool@tuxfamily.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=s-beyer@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).