git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Couder <chriscool@tuxfamily.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Stephan Beyer <s-beyer@gmx.net>,
	Daniel Barkalow <barkalow@iabervon.org>,
	Jakub Narebski <jnareb@gmail.com>
Subject: [PATCH v3 4/9] rebase -i: use "git sequencer--helper --fast-forward"
Date: Sat, 22 Aug 2009 06:16:10 +0200	[thread overview]
Message-ID: <20090822041616.4261.52894.chriscool@tuxfamily.org> (raw)
In-Reply-To: <20090822041157.4261.92491.chriscool@tuxfamily.org>

when fast forwarding.

Note that in the first hunk of this patch, there was this line:

test "a$1" = a-n && output git reset --soft $current_sha1

but the test always failed.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 git-rebase--interactive.sh |   11 +++--------
 1 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
index 0041994..7651fd6 100755
--- a/git-rebase--interactive.sh
+++ b/git-rebase--interactive.sh
@@ -154,11 +154,8 @@ pick_one () {
 		die "Could not get the parent of $sha1"
 	current_sha1=$(git rev-parse --verify HEAD)
 	if test "$no_ff$current_sha1" = "$parent_sha1"; then
-		git sequencer--helper --reset-hard $sha1 \
+		git sequencer--helper --fast-forward $sha1 \
 			"$GIT_REFLOG_ACTION" "$VERBOSE"
-		test "a$1" = a-n && output git reset --soft $current_sha1
-		sha1=$(git rev-parse --short $sha1)
-		output warn Fast forward to $sha1
 	else
 		output git cherry-pick "$@"
 	fi
@@ -238,10 +235,8 @@ pick_one_preserving_merges () {
 	done
 	case $fast_forward in
 	t)
-		output warn "Fast forward to $sha1"
-		git sequencer--helper --reset-hard $sha1 \
-			"$GIT_REFLOG_ACTION" "$VERBOSE" ||
-			die "Cannot fast forward to $sha1"
+		git sequencer--helper --fast-forward $sha1 \
+			"$GIT_REFLOG_ACTION" "$VERBOSE" || exit
 		;;
 	f)
 		first_parent=$(expr "$new_parents" : ' \([^ ]*\)')
-- 
1.6.4.271.ge010d

  parent reply	other threads:[~2009-08-22  4:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-22  4:16 [PATCH v3 0/9] more changes to port rebase -i to C using sequencer code Christian Couder
2009-08-22  4:16 ` [PATCH v3 1/9] sequencer: add "do_fast_forward()" to perform a fast forward Christian Couder
2009-08-22  7:29   ` Junio C Hamano
2009-08-22 11:19     ` Christian Couder
2009-08-22 20:15       ` Junio C Hamano
2009-08-22  4:16 ` [PATCH v3 2/9] sequencer: add "--fast-forward" option to "git sequencer--helper" Christian Couder
2009-08-22  4:16 ` [PATCH v3 3/9] sequencer: let "git sequencer--helper" callers set "allow_dirty" Christian Couder
2009-08-22  4:16 ` Christian Couder [this message]
2009-08-22  4:16 ` [PATCH v3 5/9] revert: libify pick Christian Couder
2009-08-22  4:16 ` [PATCH v3 6/9] pick: libify "pick_help_msg()" Christian Couder
2009-08-22  4:16 ` [PATCH v3 7/9] sequencer: add "do_commit()" and related functions Christian Couder
2009-08-22  4:16 ` [PATCH v3 8/9] sequencer: add "--cherry-pick" option to "git sequencer--helper" Christian Couder
2009-08-22  4:16 ` [PATCH v3 9/9] rebase -i: use "git sequencer--helper --cherry-pick" Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090822041616.4261.52894.chriscool@tuxfamily.org \
    --to=chriscool@tuxfamily.org \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=barkalow@iabervon.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jnareb@gmail.com \
    --cc=s-beyer@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).