From: Jeff King <peff@peff.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>,
Tom Werner <mojombo@gmail.com>,
Tom Preston-Werner <tom@mojombo.com>,
git@vger.kernel.org
Subject: Re: [PATCH] upload-pack: add a trigger for post-upload-pack hook
Date: Wed, 26 Aug 2009 10:19:08 -0400 [thread overview]
Message-ID: <20090826141907.GA3485@sigill.intra.peff.net> (raw)
In-Reply-To: <alpine.DEB.1.00.0908261200160.4713@intel-tinevez-2-302>
On Wed, Aug 26, 2009 at 12:06:59PM +0200, Johannes Schindelin wrote:
> > Did you get an impression that I was saying "you must add these
> > otherwise I'll reject the patch"?
>
> Well, I got the impression that you'd not accept the patch without
> additional information given by the hook, and I got the impression that
> Tom would decide as a consequence to rather live with his eternal fork
> instead of working on getting this patch included.
I don't think any of us wants that. My point in bringing it up at all
was just "is there anything obvious that we should be adding before this
makes it into master, because after that we will have to deal with an
interface change". I certainly don't want to delay a useful patch too
much while we wait for the moon.
-Peff
next prev parent reply other threads:[~2009-08-26 14:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-18 7:04 [PATCH] upload-pack: add a trigger for post-upload-pack hook Tom Preston-Werner
2009-08-25 17:43 ` Tom Werner
2009-08-25 18:45 ` Jeff King
2009-08-25 23:50 ` Junio C Hamano
2009-08-26 8:44 ` Johannes Schindelin
2009-08-26 9:03 ` Junio C Hamano
2009-08-26 10:06 ` Johannes Schindelin
2009-08-26 14:19 ` Jeff King [this message]
2009-08-26 23:39 ` Junio C Hamano
2009-08-27 0:47 ` Junio C Hamano
2009-08-27 12:09 ` Johan Sørensen
2009-08-27 13:33 ` Jakub Narebski
2009-08-29 6:17 ` Junio C Hamano
2009-08-31 18:50 ` Tom Werner
2009-08-31 23:36 ` Junio C Hamano
2009-08-27 22:56 ` Robin H. Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090826141907.GA3485@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mojombo@gmail.com \
--cc=tom@mojombo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).